Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smartthings] WIP Refactor binding to make use of new API #17855

Draft
wants to merge 80 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
85c9db9
WIP : refactoring
lo92fr Sep 17, 2023
4e8a24d
First discovering from cloud Api !
lo92fr Sep 17, 2023
5fb5f45
add ressources
lo92fr Sep 21, 2023
86cf0f3
adding oauth authentification, first working versions
lo92fr Sep 22, 2023
11a06e2
fix clientId & clientSecret to come from config
lo92fr Sep 22, 2023
c5db2ce
Refactor API call to support oAuth bearer
lo92fr Sep 22, 2023
fec29b2
code refactoring
lo92fr Sep 22, 2023
d4b1562
start review discovery to support device type and capabilities
lo92fr Sep 23, 2023
db94a81
start implementing type providers
lo92fr Sep 25, 2023
c64c2c6
Implements basic Command to very if its works !
lo92fr Sep 25, 2023
ef75049
progress on type registry implementations
lo92fr Sep 29, 2023
3586d50
add Json template
lo92fr Oct 12, 2023
7c8db5a
add json structure
lo92fr Oct 12, 2023
c95aeab
start capabilities implementations
lo92fr Oct 12, 2023
a3d3ce1
fix channelGroupTypeUUID for multiple device types
lo92fr Dec 6, 2024
7668225
Start investiguate refreshing channel state
lo92fr Dec 6, 2024
16e856c
spotless::apply
lo92fr Dec 6, 2024
86846eb
fix potential null params
lo92fr Dec 6, 2024
dd3a59f
fix potential null params
lo92fr Dec 6, 2024
7fa12fe
Start working on event handling from Smarthings Cloud Smartapps
lo92fr Dec 7, 2024
e07fcff
spotless::apply
lo92fr Dec 7, 2024
edec5a4
trigger new build
lo92fr Dec 7, 2024
e9f1f6d
try to fix compile error
lo92fr Dec 7, 2024
8970a1f
try to fix compile error
lo92fr Dec 7, 2024
6ecdc5d
fix copyright lines
lo92fr Dec 7, 2024
f42a71d
fix author and copyright missing
lo92fr Dec 7, 2024
d1504be
fix sat errors
lo92fr Dec 7, 2024
6ba1fe8
fix sat errors
lo92fr Dec 7, 2024
8d76e52
fix sat errors
lo92fr Dec 7, 2024
d10c934
refactor code to add gson serialization / deserialization
lo92fr Dec 8, 2024
49c013f
fix missing headers
lo92fr Dec 8, 2024
d8f4742
progress on automatic smartapp creation flow : first full working ver…
lo92fr Dec 9, 2024
7bc0044
core refactoring and cleanup :
lo92fr Dec 11, 2024
801cba5
spotless:apply
lo92fr Dec 11, 2024
60fd8a0
fix misssing headers
lo92fr Dec 11, 2024
f7340c7
fix bad condition in registry
lo92fr Dec 11, 2024
8c16be3
add location and room support to API
lo92fr Dec 11, 2024
5dcbb6c
move from old Json base capabilities to API based capabilities
lo92fr Dec 11, 2024
3f6eb93
spotless:apply
lo92fr Dec 11, 2024
615a235
review onboarding process
lo92fr Dec 11, 2024
49333ac
progress on channelType and capability decoding
lo92fr Dec 12, 2024
7659735
review type registry implementations (WIP):
lo92fr Dec 12, 2024
fc9c3fb
spotless:apply
lo92fr Dec 12, 2024
12d8586
review the onboarding process
lo92fr Dec 12, 2024
7e59811
refactor Servlet code
lo92fr Dec 13, 2024
ae973de
spotless::apply
lo92fr Dec 13, 2024
068b547
fix sat errors & warnings
lo92fr Dec 13, 2024
c1322c6
fix sat warnings
lo92fr Dec 13, 2024
f0212fd
fix stylecheck warnings
lo92fr Dec 13, 2024
e841c9a
fix error on missing capa key
lo92fr Dec 13, 2024
4749a7d
fix checkStyle warnings
lo92fr Dec 13, 2024
56d721b
remove SmarthubCommand
lo92fr Dec 13, 2024
39e5a1f
review / fix dependancy on discovery service
lo92fr Dec 13, 2024
8a6960a
spotless:apply
lo92fr Dec 13, 2024
b3a5c40
start implementing channel refresh
lo92fr Dec 13, 2024
b7f5e85
start adding dynamic update on event handling
lo92fr Dec 13, 2024
5ffbab1
spotless::apply
lo92fr Dec 13, 2024
c436d9f
review subscriptions handling
lo92fr Dec 13, 2024
314f177
plug back the converter to handle Smarthings / Openhab type conversion
lo92fr Dec 14, 2024
31eed8e
code cleanup, remove old unused class
lo92fr Dec 14, 2024
0d23094
introduce converter also on conversion from Smartthins to Openhab
lo92fr Dec 14, 2024
61195b4
spotless:apply
lo92fr Dec 14, 2024
2ba7c55
fix device refreshDevice
lo92fr Dec 15, 2024
f6a2eeb
spotless:apply
lo92fr Dec 15, 2024
533c2b9
fix bad flow in SmarthingsThingHandler
lo92fr Dec 15, 2024
a4155d7
fix SmartthingsColorConverter, still more work need to be done
lo92fr Dec 15, 2024
4b93ebc
remove other color converter, useless
lo92fr Dec 15, 2024
29e6fd7
refactor converter structure
lo92fr Dec 16, 2024
f84081f
spotless:apply
lo92fr Dec 16, 2024
f46987a
fix code analysis error on logger
lo92fr Dec 16, 2024
b19164d
start updating the doc
lo92fr Dec 17, 2024
b6bf516
Start working on new documentation
lo92fr Dec 18, 2024
f5b41b7
make clientId & clientSecret optional as they are now automatically r…
lo92fr Dec 18, 2024
41ffc5d
fix subscriptions registration, was using wrong tokens
lo92fr Dec 18, 2024
d69db6d
review exception handing on network Connector
lo92fr Dec 18, 2024
d66df9d
add temp fix for class cast exception
lo92fr Dec 18, 2024
57ff83c
add support to options so we can handle command that use enum
lo92fr Dec 18, 2024
9e553d2
some review on exception handling
lo92fr Dec 20, 2024
683b59b
fix compilation errors.
lo92fr Dec 30, 2024
d71d76c
fix sat errors
lo92fr Dec 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions bundles/org.openhab.binding.smartthings/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ This binding integrates the Samsung Smartthings Hub into openHAB.

## Supported things

This binding supports most of the Smartthings devices that are defined in the [Smartthings Capabilities list](https://developer-preview.smartthings.com/docs/devices/capabilities/capabilities-reference/). If you find a device that doesn't work [follow these instructions](doc/Troubleshooting.md) to collect the required data so it can be added in a future release.
This binding supports most of the Smartthings devices that are defined in the [Smartthings Capabilities list](https://developer-preview.smartthings.com/docs/devices/capabilities/capabilities-reference/).

If you find a device that doesn't work [follow these instructions](doc/Troubleshooting.md) to collect the required data so it can be added in a future release.

## Discovery

Expand All @@ -13,7 +15,24 @@ Discovery is supported by the Smartthings binding and is run automatically on st

## Smartthings Configuration

Prior to running the binding the Smartthings hub must have the required openHAB software installed. [Follow these instructions](doc/SmartthingsInstallation.md)
You will need to get a token before setup the binding.

- For this, go to the following ULR : https://account.smartthings.com/tokens/new


- Then login with you smartthings account / password.


- On the next page, give a token name (arbitrary), select all the Oauth scope.

![](doc/TokenCreate.png)


- On the last page, the token will be displayed.

![](doc/TokenConfirmation.png)

- Make a copy of this token, and fill it on the openhab Smarthings Cloud Hub device.

**The binding will not work until this part has been completed, do not skip this part of the setup.**

Expand Down

This file was deleted.

Loading