[shelly] Re-Add/Fix Shelly Plus UNI support #17816
Conversation
Signed-off-by: Markus Michels <[email protected]>
markus7017
added
awaiting feedback
bundles/org.openhab.binding.shelly/src/main/resources/OH-INF/thing/shellyGen1_sensor.xml
Outdated
Show resolved
Hide resolved
|
@markus7017 - the label "awaiting feedback" is used when waiting for the contributor (you). If your PR is not yet ready for being merged, you can block it by marking it as a draft (and/or adding label "work in progress"). Or if awaiting user tests, you can add label "additional testing preferred". |
lsiepel
added
bug
…hing/shellyGen1_sensor.xml Co-authored-by: lsiepel <[email protected]> Signed-off-by: Jacob Laursen <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/incorporating-matter/127907/696 |
|
JFTR; i think this should be merged before code freeze. I doubt there is anything left to fix, but even if there is, it can be fixed easily before stable. Otherwise it would take way months longer to get this regression fix into stable. |
Strictly speaking, there is nothing preventing it from being merged:
Still, I would prefer if @markus7017 could at least respond here what his intention was by adding the label "awaiting feedback", and if the PR is indeed ready to be merged. If we don't hear from him before code freeze, let's merge it. Is that okay with you? EDIT: Additionally there should probably be a breaking note in openhab-distro which is unlikely to be added when the PR author doesn't respond. |
Due to a previous change in Gen2/3 detection the Shelly Plus UNI gets not discovery anymore.
This fix creates a dedicated thing type, because gen 2/3 detection is now based on the prefix of the thing type being shellyplus or shellypro. An existing thing has to be deleted and re-discovered.