Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsscripting] Upgrade GraalJS from 22.0.0.2 to 24.1.1 #17720

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Nov 8, 2024

Changelog: https://github.com/oracle/graaljs/blob/master/CHANGELOG.md#version-2410

FYI I wondered if we could OSGi-ify org.graalvm.polglot:polyglot and possibly other dependencies and what would be the benefit of this.
This is tested on my dev system running 5.0.0 snapshot.

@florian-h05 florian-h05 added this to the 5.0 milestone Dec 17, 2024
@florian-h05 florian-h05 marked this pull request as ready for review December 17, 2024 15:18
@florian-h05 florian-h05 marked this pull request as draft December 17, 2024 15:19
The packaging had to be changed to building an uber-JAR because of
https://github.com/oracle/graaljs/blob/master/CHANGELOG.md#version-2310.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 marked this pull request as ready for review December 22, 2024 01:04
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel merged commit 5e7d2fc into openhab:main Dec 22, 2024
3 checks passed
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Dec 22, 2024
@florian-h05 florian-h05 deleted the jsscripting-upgrade branch December 22, 2024 10:18
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* [jsscripting] Upgrade GraalJS to 23.0.6

Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
DrRSatzteil pushed a commit to DrRSatzteil/openhab-addons that referenced this pull request Jan 3, 2025
* [jsscripting] Upgrade GraalJS to 23.0.6

Signed-off-by: Florian Hotze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants