-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plclogo] Remove org.apache.commons.net.util.SubnetUtils #17408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
lsiepel
added
enhancement
An enhancement or new feature for an existing add-on
and removed
awaiting other PR
Depends on another PR
labels
Oct 7, 2024
Signed-off-by: Leo Siepel <[email protected]>
lsiepel
changed the title
[pclogo] Remove org.apache.commons.net.util.SubnetUtils
[plclogo] Remove org.apache.commons.net.util.SubnetUtils
Oct 8, 2024
lolodomo
reviewed
Oct 12, 2024
...lclogo/src/main/java/org/openhab/binding/plclogo/internal/discovery/PLCDiscoveryService.java
Show resolved
Hide resolved
lolodomo
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* Remove apache Signed-off-by: Leo Siepel <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* Remove apache Signed-off-by: Leo Siepel <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* Remove apache Signed-off-by: Leo Siepel <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on : openhab/openhab-core#4375