-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ecovacs] Fix expired token handling for XML-over-MQTT models #17333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvement suggestion. This is marked as draft, is that because it needs some testing or more work?
.../binding/ecovacs/internal/api/impl/dto/response/portal/AbstractPortalIotCommandResponse.java
Outdated
Show resolved
Hide resolved
Correct, I asked for testing in #15961 |
Test confirmed in the related issue |
At least the Deebot 900 sends an unusual error response in case of expired token. Fixes openhab#15961 Signed-off-by: Danny Baumann <[email protected]>
a97a2c5
to
62c1bc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
…b#17333) At least the Deebot 900 sends an unusual error response in case of expired token. Fixes openhab#15961 Signed-off-by: Danny Baumann <[email protected]>
…b#17333) At least the Deebot 900 sends an unusual error response in case of expired token. Fixes openhab#15961 Signed-off-by: Danny Baumann <[email protected]>
…b#17333) At least the Deebot 900 sends an unusual error response in case of expired token. Fixes openhab#15961 Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
At least the Deebot 900 sends an unusual error response in case of expired token.
Fixes #15961