Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecovacs] Fix expired token handling for XML-over-MQTT models #17333

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

maniac103
Copy link
Contributor

At least the Deebot 900 sends an unusual error response in case of expired token.

Fixes #15961

@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Aug 29, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvement suggestion. This is marked as draft, is that because it needs some testing or more work?

@maniac103
Copy link
Contributor Author

This is marked as draft, is that because it needs some testing or more work?

Correct, I asked for testing in #15961

@lsiepel
Copy link
Contributor

lsiepel commented Oct 25, 2024

This is marked as draft, is that because it needs some testing or more work?

Correct, I asked for testing in #15961

Test confirmed in the related issue

@maniac103 maniac103 marked this pull request as ready for review November 5, 2024 11:09
At least the Deebot 900 sends an unusual error response in case of
expired token.

Fixes openhab#15961

Signed-off-by: Danny Baumann <[email protected]>
@maniac103 maniac103 force-pushed the deebot-900-token-error branch from a97a2c5 to 62c1bc0 Compare November 5, 2024 11:13
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 16e1c64 into openhab:main Nov 5, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 5, 2024
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
…b#17333)

At least the Deebot 900 sends an unusual error response in case of
expired token.

Fixes openhab#15961

Signed-off-by: Danny Baumann <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
…b#17333)

At least the Deebot 900 sends an unusual error response in case of
expired token.

Fixes openhab#15961

Signed-off-by: Danny Baumann <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
…b#17333)

At least the Deebot 900 sends an unusual error response in case of
expired token.

Fixes openhab#15961

Signed-off-by: Danny Baumann <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ecovacs] Robot not updated after some time
2 participants