[freeboxos] Add unitHint on few channel types #17259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
the
enhancement
Also remove an unused channel type "bandwidth". Also avoid unneeded unit conversion when updating channel state. Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
force-pushed
the
freeboxos_channel_uom
branch
from
d949655 to
5712d5c
Compare
clinique
approved these changes
Aug 15, 2024
jlaur
reviewed
Aug 15, 2024
bundles/org.openhab.binding.freeboxos/src/main/resources/OH-INF/thing/channel-types.xml
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]>
clinique
approved these changes
Aug 15, 2024
lsiepel
approved these changes
Aug 20, 2024
@clinique - I see you liked that message (which is also ambiguous 😁)... but to be sure, did you see this comment: #17259 (comment)? |
Don't this that I like being ambiguous :-). At the moment I don't get it as being so ! |
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
* [freeboxos] Add unitHint on few channel types Also remove an unused channel type "bandwidth". Also avoid unneeded unit conversion when updating channel state. Signed-off-by: Laurent Garnier <[email protected]>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* [freeboxos] Add unitHint on few channel types Also remove an unused channel type "bandwidth". Also avoid unneeded unit conversion when updating channel state. Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* [freeboxos] Add unitHint on few channel types Also remove an unused channel type "bandwidth". Also avoid unneeded unit conversion when updating channel state. Signed-off-by: Laurent Garnier <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* [freeboxos] Add unitHint on few channel types Also remove an unused channel type "bandwidth". Also avoid unneeded unit conversion when updating channel state. Signed-off-by: Laurent Garnier <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* [freeboxos] Add unitHint on few channel types Also remove an unused channel type "bandwidth". Also avoid unneeded unit conversion when updating channel state. Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove an unused channel type "bandwidth".
Also avoid unneeded unit conversion when updating channel state.
Signed-off-by: Laurent Garnier [email protected]