Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Improve escaping of URLs #17110

Merged
merged 4 commits into from
Jul 24, 2024
Merged

[http] Improve escaping of URLs #17110

merged 4 commits into from
Jul 24, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jul 20, 2024

Related to #12350
Related to #17039

@jamesmelville FYI

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Jul 20, 2024
@J-N-K J-N-K requested a review from a team as a code owner July 20, 2024 19:04
@lsiepel lsiepel requested a review from jamesmelville July 21, 2024 08:15
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Will also wait for @jamesmelville to comment before merge.

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: Jan N. Klug <[email protected]>
Copy link
Contributor

@jamesmelville jamesmelville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm only on a phone but I think this looks good. I think you've now made the change backwards compatible for users using the old escapedURL flag which is great. Minor comments on naming. Thanks @J-N-K @lsiepel

J-N-K and others added 2 commits July 24, 2024 09:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: James Melville <[email protected]>
Signed-off-by: J-N-K <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: James Melville <[email protected]>
Signed-off-by: J-N-K <[email protected]>
@J-N-K
Copy link
Member Author

J-N-K commented Jul 24, 2024

@jamesmelville Thanks!

@lsiepel lsiepel merged commit fd4dd89 into openhab:main Jul 24, 2024
4 of 5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Jul 24, 2024
@J-N-K J-N-K deleted the http branch July 28, 2024 17:22
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
* [http] Improve escaping of URLs

Signed-off-by: Jan N. Klug <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024

Verified

This commit was signed with the committer’s verified signature.
pgfeller Patrik Gfeller
* [http] Improve escaping of URLs

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [http] Improve escaping of URLs

Signed-off-by: Jan N. Klug <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [http] Improve escaping of URLs

Signed-off-by: Jan N. Klug <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* [http] Improve escaping of URLs

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants