-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[http] Properly escape + character in query string #17042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
I don't think the Jenkins failure is related to this change. |
lsiepel
added
rebuild
Triggers Jenkins PR build
and removed
rebuild
Triggers Jenkins PR build
labels
Jul 12, 2024
lsiepel
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for jenkins to finish.
This should also be cherry-picked to 4.2.x |
lsiepel
added
the
patch
A PR that has been cherry-picked to a patch release branch
label
Jul 12, 2024
lsiepel
pushed a commit
to lsiepel/openhab-addons
that referenced
this pull request
Jul 12, 2024
* [http] Properly escape + character in query string Signed-off-by: Jan N. Klug <[email protected]>
lsiepel
pushed a commit
that referenced
this pull request
Jul 12, 2024
* [http] Properly escape + character in query string Signed-off-by: Jan N. Klug <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Jul 18, 2024
* [http] Properly escape + character in query string Signed-off-by: Jan N. Klug <[email protected]>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* [http] Properly escape + character in query string Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* [http] Properly escape + character in query string Signed-off-by: Jan N. Klug <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* [http] Properly escape + character in query string Signed-off-by: Jan N. Klug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17039
Reported on the forum: https://community.openhab.org/t/openhab-4-2-release-discussion/157076/35 and in private communication
This also allows pre-escaped characters in the
stateExtension
andcommandExtension
if the automatic escaping is not sufficient.