Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Properly escape + character in query string #17042

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jul 11, 2024

Fixes #17039

Reported on the forum: https://community.openhab.org/t/openhab-4-2-release-discussion/157076/35 and in private communication

This also allows pre-escaped characters in the stateExtension and commandExtension if the automatic escaping is not sufficient.

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Jul 11, 2024
@J-N-K J-N-K requested a review from a team as a code owner July 11, 2024 17:19
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the rebuild Triggers Jenkins PR build label Jul 11, 2024
@J-N-K
Copy link
Member Author

J-N-K commented Jul 11, 2024

I don't think the Jenkins failure is related to this change.

@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 12, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for jenkins to finish.

@J-N-K
Copy link
Member Author

J-N-K commented Jul 12, 2024

This should also be cherry-picked to 4.2.x

@lsiepel lsiepel merged commit f8e5644 into openhab:main Jul 12, 2024
5 checks passed
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Jul 12, 2024
@lsiepel lsiepel added this to the 4.3 milestone Jul 12, 2024
lsiepel pushed a commit to lsiepel/openhab-addons that referenced this pull request Jul 12, 2024
* [http] Properly escape + character in query string

Signed-off-by: Jan N. Klug <[email protected]>
lsiepel pushed a commit that referenced this pull request Jul 12, 2024
* [http] Properly escape + character in query string

Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K deleted the http branch July 14, 2024 10:11
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Jul 18, 2024
* [http] Properly escape + character in query string

Signed-off-by: Jan N. Klug <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* [http] Properly escape + character in query string

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [http] Properly escape + character in query string

Signed-off-by: Jan N. Klug <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [http] Properly escape + character in query string

Signed-off-by: Jan N. Klug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[http] Regression in 4.2, removal of escapedUrl parameter
2 participants