[shelly] Add test coverage for thing type mapping #17040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
added
rebuild
|
cool, thanks for the effort. I didn't checked that all types are in, but what I understand is that valid combinations are verified as well as invalid combos? LGTM |
I'm not sure what you mean by invalid combos, but I don't think so. The tests verify that the |
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Jul 18, 2024
Signed-off-by: Jacob Laursen <[email protected]>
lsiepel
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Jacob Laursen <[email protected]>
lsiepel
added
the
patch
|
Needed this to cherry pick into 4.2. due to another depending PR that was build on top of this. |
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Jacob Laursen <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Jacob Laursen <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some initial test coverage related to thing type and API mapping:
The intention is to document the current logic and to reduce risk when refactoring this logic.
Related to #17011