[homekit] Sort characteristics in HomekitCharacteristicFactory #17033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are so many shared characteristics now, and so many accessories they belong to, there is no longer any groupings that make sense. so just sort solely by characteristic/method nome Signed-off-by: Cody Cutrer <[email protected]>
lsiepel
approved these changes
Jul 9, 2024
wborn
added
rebuild
yfre
approved these changes
Jul 10, 2024
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jul 12, 2024
…ab#17033) there are so many shared characteristics now, and so many accessories they belong to, there is no longer any groupings that make sense. so just sort solely by characteristic/method name Signed-off-by: Cody Cutrer <[email protected]>
jlaur
changed the title
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Jul 18, 2024
…ab#17033) there are so many shared characteristics now, and so many accessories they belong to, there is no longer any groupings that make sense. so just sort solely by characteristic/method name Signed-off-by: Cody Cutrer <[email protected]>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…ab#17033) there are so many shared characteristics now, and so many accessories they belong to, there is no longer any groupings that make sense. so just sort solely by characteristic/method name Signed-off-by: Cody Cutrer <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…ab#17033) there are so many shared characteristics now, and so many accessories they belong to, there is no longer any groupings that make sense. so just sort solely by characteristic/method name Signed-off-by: Cody Cutrer <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…ab#17033) there are so many shared characteristics now, and so many accessories they belong to, there is no longer any groupings that make sense. so just sort solely by characteristic/method name Signed-off-by: Cody Cutrer <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
…ab#17033) there are so many shared characteristics now, and so many accessories they belong to, there is no longer any groupings that make sense. so just sort solely by characteristic/method name Signed-off-by: Cody Cutrer <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are so many shared characteristics now, and so many accessories they belong to, there is no longer any groupings that make sense. so just sort solely by characteristic/method name. While the diff is huge, no actual code changes were made. Once this is merged, it will be easier to work on multiple PRs at the same time without conflicting with each other.