[aWattar] Add inverted best price

[tl-photography]

The goal is to add an inverted best price to the aWattar add-on.

If you set the ìnverted` flag via configuration it will return the inverted result of a best price.
So if you set for example 4h and inverted, the four hours with the highest price will be selected.

Does currently not work with the consectuive flag.

[AndyNeubacher]

As i understand this is what i've intended with the #16813, but in my situation i'm using both ... the "BestPrice" AND the "WorstPrice".
Means i've to decide inverted OR not-inverted - so IMHO for me that doesn't really help!?

Or can i add two BestPrice-Things at the same time?

[J-N-K]

Yes, you can add as many as you want.

[Herschdorfer]

As i understand this is what i've intended with the #16813, but in my situation i'm using both ... the "BestPrice" AND the "WorstPrice". Means i've to decide inverted OR not-inverted - so IMHO for me that doesn't really help!?

Or can i add two BestPrice-Things at the same time?

You could now add two things, one inverted and one normal. That should solve your problem.

[Wolfgang1966]

There is maybe one scenario that the "inverted best price" logic could not cover: If for any reason you want to have a consecutive worst price range, this would not work, as the inverted consecutive best price range could give two ranges, one from midnight to the start of the bestprice range, the other one from the end of the bestprice range to midnight.

Also an inverted WorstPrice Thing would then give two timeranges excluding the worst prices of one day.

If there is really a usecase for that, then the WorstPrice thing would be needed.

Is this the use case you are thinking of?

[tl-photography]

Thanks for the review!

The combination of inverted price range and the 'consecutive' flag is not implemented. Please have a look at my added docs here https://github.com/openhab/openhab-addons/pull/16877/files#diff-a36be23b36348afb82551140aebb05c720bd773cf7755c6a3a6e0cfa55da8890R48.

I also added the inverted price range only to the non-consecutive code path.

It's basically just a quality of life change, where I can specifically tell to, for example, not switch on the water boiler on the 10h with the highest price.

It is also a request in this issue: #16813

[Wolfgang1966]

LGTM. Thank you very much

[lsiepel]

Can you fix the conflicts?

[tl-photography]

Sure, but it might take me unfortunately until Wednesday.