Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lastnpe EEA to 2.4.0 #16875

Merged
merged 23 commits into from
Jul 11, 2024
Merged

Update lastnpe EEA to 2.4.0 #16875

merged 23 commits into from
Jul 11, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jun 16, 2024 •
edited
Loading

Resolves: #10396

The reason is that the new version fixes that Optional.orElse can return null values (based on the parameter).
There is quite some code using Optional.orElse expecting the result to be non-null.

In most cases i wrapped the optional in Objects.requireNonNull(..) and in some cases i removed the optional.

At time of writing bindings A-D have been adjusted and i like to get some feedback before proceeding to fix all.
Edit: Moved on to bindings A - K

JFTR: to be merged after 4.2 release as i cannot test all bindings.

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Jun 16, 2024
@lsiepel lsiepel added the work in progress A PR that is not yet ready to be merged label Jun 16, 2024
@J-N-K
Copy link
Member

J-N-K commented Jun 16, 2024

The problem is that we can't do proper null annotations with EEA. Unfortunately there is no will on Eclipse side to fix that. We would need something like "non-null if argument is non-null". This also applies to Map.compute and similar methods.

@lsiepel
Copy link
Contributor Author

lsiepel commented Jun 16, 2024

The problem is that we can't do proper null annotations with EEA. Unfortunately there is no will on Eclipse side to fix that. We would need something like "non-null if argument is non-null". This also applies to Map.compute and similar methods.

Is there some kind of link to that discussion? And more important do you have some thoughts on how to proceed in relation to this PR?

@J-N-K
Copy link
Member

J-N-K commented Jun 16, 2024

lastnpe/eclipse-null-eea-augments#116 and linked issues

https://bugs.eclipse.org/bugs/show_bug.cgi?id=575822

@lsiepel
Fix review comments
145c1b1 
Signed-off-by: Leo Siepel <[email protected]>
@morph166955
Copy link
Contributor

I can't validate this any time soon for the AndroidTV/PhillipsTV bit. Is this a Java 17 update or would this still be backwards compatible to Java 11? I'm about to kill off the 3.x compatibility but I haven't yet so I'm trying to keep that in mind still.

@lsiepel
Copy link
Contributor Author

lsiepel commented Jun 16, 2024

I can't validate this any time soon for the AndroidTV/PhillipsTV bit. Is this a Java 17 update or would this still be backwards compatible to Java 11? I'm about to kill off the 3.x compatibility but I haven't yet so I'm trying to keep that in mind still.

As far as i know this should be java 11 compatible. Maybe 4.2 is a good point to move on anyway.

@lsiepel
Bindings E- K
91221a1 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from pail23 as a code owner June 23, 2024 14:55
lsiepel added 2 commits June 23, 2024 17:05
@lsiepel
Style improvements
52b75a2 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
More improvements
f946548 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from mrbig as a code owner June 23, 2024 19:20
@lsiepel lsiepel removed the work in progress A PR that is not yet ready to be merged label Jun 23, 2024
weymann
weymann approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@weymann weymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for sensorcommunity

@wborn wborn added this to the 4.3 milestone Jun 24, 2024
wborn
wborn approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍

@lsiepel lsiepel mentioned this pull request Jul 4, 2024
Merged
bern77
bern77 approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@bern77 bern77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for helioseasycontrol

@lsiepel
Copy link
Contributor Author

lsiepel commented Jul 7, 2024

@openhab/add-ons-maintainers now 4.3 development is started, would be nice to have this merged sooner then later.

@wborn
Copy link
Member

wborn commented Jul 8, 2024

Looks like some new code got added that no longer compiles with the newer EEAs.
Can you update that too @lsiepel? After that we can merge the PR.

@lsiepel lsiepel requested a review from jsjames as a code owner July 9, 2024 21:08
@lsiepel
Copy link
Contributor Author

lsiepel commented Jul 10, 2024

@openhab/add-ons-maintainers ping

@wborn wborn merged commit 5e0e9ce into openhab:main Jul 11, 2024
4 of 5 checks passed
@lsiepel lsiepel deleted the update-last-npe branch July 11, 2024 20:58
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jul 12, 2024
@lsiepel @psmedley
Update lastnpe EEA to 2.4.0 (openhab#16875)
58a7f95 
Signed-off-by: Leo Siepel <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Jul 18, 2024
@lsiepel @andrewfg
Update lastnpe EEA to 2.4.0 (openhab#16875)
dadad63 
Signed-off-by: Leo Siepel <[email protected]>
@andrewfg andrewfg mentioned this pull request Aug 19, 2024
Merged
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@lsiepel @pgfeller
Update lastnpe EEA to 2.4.0 (openhab#16875)
ee8df77 
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@lsiepel @joni1993
Update lastnpe EEA to 2.4.0 (openhab#16875)
a1bf7f5 
Signed-off-by: Leo Siepel <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@lsiepel @matchews
Update lastnpe EEA to 2.4.0 (openhab#16875)
3dba4bd 
Signed-off-by: Leo Siepel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

@mlobstein mlobstein mlobstein approved these changes

@weymann weymann weymann approved these changes

@ecdye ecdye ecdye approved these changes

@bern77 bern77 bern77 approved these changes

@wborn wborn wborn approved these changes

@theater theater theater approved these changes

@david-pace david-pace david-pace approved these changes

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

@druciak druciak druciak approved these changes

@DerOetzi DerOetzi Awaiting requested review from DerOetzi DerOetzi is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@rmichalak rmichalak Awaiting requested review from rmichalak rmichalak is a code owner

@caffineehacker caffineehacker Awaiting requested review from caffineehacker caffineehacker is a code owner

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@morph166955 morph166955 Awaiting requested review from morph166955 morph166955 is a code owner

@HolgerHees HolgerHees Awaiting requested review from HolgerHees HolgerHees is a code owner

@ccutrer ccutrer Awaiting requested review from ccutrer ccutrer is a code owner

@jimtng jimtng Awaiting requested review from jimtng jimtng is a code owner

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

@yfre yfre Awaiting requested review from yfre yfre is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@andrewfg andrewfg Awaiting requested review from andrewfg andrewfg is a code owner

@Wire82 Wire82 Awaiting requested review from Wire82 Wire82 is a code owner

@ramack ramack Awaiting requested review from ramack ramack is a code owner

@chingon007 chingon007 Awaiting requested review from chingon007 chingon007 is a code owner

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@Andy2003 Andy2003 Awaiting requested review from Andy2003 Andy2003 is a code owner

@fruggy83 fruggy83 Awaiting requested review from fruggy83 fruggy83 is a code owner

@gdolfen gdolfen Awaiting requested review from gdolfen gdolfen is a code owner

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@maniac103 maniac103 Awaiting requested review from maniac103 maniac103 is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@ntruchsess ntruchsess Awaiting requested review from ntruchsess ntruchsess is a code owner

@dalgwen dalgwen Awaiting requested review from dalgwen dalgwen is a code owner

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

@fwolter fwolter Awaiting requested review from fwolter fwolter is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@renescherer renescherer Awaiting requested review from renescherer renescherer is a code owner

@pacive pacive Awaiting requested review from pacive pacive is a code owner

@MikeJMajor MikeJMajor Awaiting requested review from MikeJMajor MikeJMajor is a code owner

@tisoft tisoft Awaiting requested review from tisoft tisoft is a code owner

@dougculnane dougculnane Awaiting requested review from dougculnane dougculnane is a code owner

@andibraeu andibraeu Awaiting requested review from andibraeu andibraeu is a code owner

@appzer appzer Awaiting requested review from appzer appzer is a code owner

@Confectrician Confectrician Awaiting requested review from Confectrician Confectrician is a code owner

@lujop lujop Awaiting requested review from lujop lujop is a code owner

@Jamstah Jamstah Awaiting requested review from Jamstah Jamstah is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@mrbig mrbig Awaiting requested review from mrbig mrbig is a code owner

@jsjames jsjames Awaiting requested review from jsjames jsjames is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Upgrade lastnpe EEA to 2.4.0