[ecovacs] Handle invalid JSON responses properly #16466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
reviewed
Mar 11, 2024
...ding.ecovacs/src/main/java/org/openhab/binding/ecovacs/internal/api/impl/EcovacsApiImpl.java
Outdated
Show resolved
Hide resolved
The API has differing responses depending on device type. If our understanding of the JSON format differs from that of the API, make sure to properly set the thing OFFLINE and to log a meaningful message. Related to openhab#16187 Signed-off-by: Danny Baumann <[email protected]>
maniac103
force-pushed
the
ecovacs-handle-invalid-response
branch
from
8b04bf6 to
8ee4bf8
Compare
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Mar 12, 2024
The API has differing responses depending on device type. If our understanding of the JSON format differs from that of the API, make sure to properly set the thing OFFLINE and to log a meaningful message. Related to openhab#16187 Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
The API has differing responses depending on device type. If our understanding of the JSON format differs from that of the API, make sure to properly set the thing OFFLINE and to log a meaningful message. Related to openhab#16187 Signed-off-by: Danny Baumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API has differing responses depending on device type. If our understanding of the JSON format differs from that of the API, make sure to properly set the thing OFFLINE and to log a meaningful message.
Related to #16187