Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAT warning when jSerialComm, PureJavaComm imports are used #15952

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Nov 25, 2023

Add-ons should use the OH serial transport and not their own serial communication libraries.

Related to #7573

Add-ons should use the OH serial transport and not their own serial communication libraries.

Related to openhab#7573

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn requested a review from a team as a code owner November 25, 2023 08:40
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 1c8ce7c into openhab:main Nov 25, 2023
2 checks passed
@jlaur jlaur added this to the 4.1 milestone Nov 25, 2023
@wborn wborn deleted the sat-serial-impl-warning branch November 25, 2023 13:38
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
…hab#15952)

Add-ons should use the OH serial transport and not their own serial communication libraries.

Related to openhab#7573

Signed-off-by: Wouter Born <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…hab#15952)

Add-ons should use the OH serial transport and not their own serial communication libraries.

Related to openhab#7573

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants