[energidataservice] Rename channels net-tariff and transmission-net-tariff
#15938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
force-pushed
the
energidataservice-net-grid
branch
from
a4a4d97 to
8477862
Compare
jlaur
force-pushed
the
energidataservice-net-grid
branch
from
8477862 to
e0a46b9
Compare
Signed-off-by: Jacob Laursen <[email protected]>
jlaur
force-pushed
the
energidataservice-net-grid
branch
from
e0a46b9 to
24b8ae7
Compare
lolodomo
reviewed
Nov 23, 2023
bundles/org.openhab.binding.energidataservice/src/main/resources/OH-INF/update/instructions.xml
Show resolved
Hide resolved
lolodomo
added
the
enhancement
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Nov 26, 2023
Signed-off-by: Jacob Laursen <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename:
This was introduced with the initial contribution in 4.0 because of a bad translation from Danish to English (usually net translates to net, but not in this terminology).
Unfortunately it's a breaking change since the channels are renamed in order to keep everything consistent.
Based on threads in the community forum, I assess that the userbase is still relatively small and therefore worth to do this now to get the terminology right. A follow-up PR towards openhab-distro with a breaking note will be made if accepted.
Also change the order in general (documentation, JSON, etc.), so that transmission grid tariff is after system tariff and before electricity taxes, as this seems more natural since both system tariff and transmission grid tariff are for Energinet.