Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[energidataservice] Rename price element to price component #15935

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Nov 20, 2023

Renamed the concept of price element to price component.

The total electricity price consists of the following components:

  • Spot price
  • Grid tariff
  • System tariff
  • Electricity tax
  • Grid transmission tariff

I think price components sounds more fitting in this context to refer to the individual parts that make up the total price.

@jlaur jlaur requested a review from a team November 20, 2023 19:35
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit b2b7602 into openhab:main Nov 20, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Nov 20, 2023
@jlaur jlaur deleted the energidataservice-price-component branch November 23, 2023 18:58
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants