Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] implement effect channel for light #15914

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Nov 18, 2023

No description provided.

@ccutrer ccutrer requested a review from antroids as a code owner November 18, 2023 22:26
@ccutrer ccutrer force-pushed the mqtt-homeassistant-light-effects branch from ef0b28c to a82f5d2 Compare November 18, 2023 22:35
@ccutrer ccutrer force-pushed the mqtt-homeassistant-light-effects branch from a82f5d2 to aa62ae4 Compare November 18, 2023 22:41
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Nov 18, 2023
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

Waiting for @antroids approval before merging because my knowledge of this binding is too much limited.

Copy link
Contributor

@antroids antroids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thank you!

@lolodomo lolodomo merged commit 44e32d3 into openhab:main Nov 19, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Nov 19, 2023
@ccutrer ccutrer deleted the mqtt-homeassistant-light-effects branch November 21, 2023 00:03
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants