Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build addon xml #15870

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Build addon xml #15870

merged 1 commit into from
Dec 4, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Nov 8, 2023 •
edited
Loading

Related to openhab/openhab-core#3865
Supersedes #15780

@J-N-K
build addon xml
a9a79b0 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the awaiting other PR Depends on another PR label Nov 8, 2023
@J-N-K J-N-K requested a review from a team as a code owner November 8, 2023 20:11
This was referenced Nov 9, 2023
Merged
Closed
@andrewfg
Copy link
Contributor

andrewfg commented Nov 10, 2023 •
edited
Loading

A minor issue concerning the generated xml .. to ensure 'proper' xml .. I think the addon-header.xml should include a reference to the over-wrap xml schema file addon-info-list-1.0.0.xsd (which I have created in my PR in 'org.openhab.core.addon') before the copyright declaration..

<?xml version="1.0" encoding="UTF-8"?>
==> insert schema and namespace reference here
<!--

	Copyright (c) 2010-2023 Contributors to the openHAB project

	See the NOTICE file(s) distributed with this work for additional
	information.

	This program and the accompanying materials are made available under the
	terms of the Eclipse Public License 2.0 which is available at
	http://www.eclipse.org/legal/epl-2.0

	SPDX-License-Identifier: EPL-2.0

-->
<addon-info-list>
	<addons>
<addon:addon id="groovyscripting" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xmlns:addon="https://openhab.org/schemas/addon/v1.0.0"
	xsi:schemaLocation="https://openhab.org/schemas/addon/v1.0.0 https://openhab.org/schemas/addon-1.0.0.xsd">

	<type>automation</type>
	<name>Groovy Scripting</name>
	<description>This adds a Groovy script engine.</description>
	<connection>none</connection>

</addon:addon>
...

</addons>
</addon-info-list>

@J-N-K
Copy link
Member Author

J-N-K commented Nov 10, 2023

IMO there should not be a header in an auto-generated XML file. We don'T have the headers in the add-ons either.

@andrewfg
Copy link
Contributor

there should not be a header in an auto-generated XML file

Ok. (But it opens the question why therefore is a copyright message needed? .. )

andrewfg
andrewfg approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewfg andrewfg removed the awaiting other PR Depends on another PR label Nov 20, 2023
@mherwege
Copy link
Contributor

LGTM.

@lolodomo
Copy link
Contributor

@wborn : maybe you could review this one ?

wborn
wborn approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! 👍

kaikreuzer
kaikreuzer approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess this can already be merged without having to wait for the other PRs.

@kaikreuzer kaikreuzer merged commit a850df1 into openhab:main Dec 4, 2023
@kaikreuzer kaikreuzer added this to the 4.1 milestone Dec 4, 2023
@J-N-K J-N-K deleted the addonxml branch December 5, 2023 06:40
@jlaur jlaur mentioned this pull request Jan 1, 2024
Merged
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@J-N-K @austvik
build addon xml (openhab#15870)
d882d85 
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@andrewfg andrewfg andrewfg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@J-N-K @andrewfg @mherwege @lolodomo @kaikreuzer @wborn