Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netatmo] Enhance errored modules handling #15866

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Nov 8, 2023

Resolves #15858

While analyzing this issue, I identified that errored module handled at home level was partial. Fixed.
Strengthened getOpt

@clinique clinique added bug An unexpected problem or unintended behavior of an add-on work in progress A PR that is not yet ready to be merged labels Nov 8, 2023
@clinique clinique self-assigned this Nov 8, 2023
@clinique clinique requested a review from lolodomo as a code owner November 8, 2023 13:23
@clinique
Copy link
Contributor Author

Thinking of it twice, I was sure I already faced the same case. It is the issue #15212 . If nothing is defined the API gives a null where the binding expects (wrongly) an empty list.

@clinique clinique removed the work in progress A PR that is not yet ready to be merged label Nov 17, 2023
@clinique
Copy link
Contributor Author

@lolodomo, @jlaur : ready for review

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 596015d into openhab:main Nov 17, 2023
@lolodomo lolodomo added this to the 4.1 milestone Nov 17, 2023
@clinique clinique deleted the netatmo_15858 branch November 18, 2023 08:56
@jlaur
Copy link
Contributor

jlaur commented Nov 18, 2023

@clinique, @lolodomo - should we cherry-pick this for 4.0.x?

@clinique
Copy link
Contributor Author

@clinique, @lolodomo - should we cherry-pick this for 4.0.x?

Yes it should be

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
* Resolves issue openhab#15858
* Enhance null control in DTO

---------

Signed-off-by: clinique <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* Resolves issue openhab#15858
* Enhance null control in DTO

---------

Signed-off-by: clinique <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Netatmo] Binding fail with exception
3 participants