Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mycroft] gson checkstyle fixes #15829

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[mycroft] gson checkstyle fixes #15829

merged 1 commit into from
Nov 3, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Oct 31, 2023

Some minor checkstyle fixes for gson fields

@lsiepel
gson fields alias
4d60fa6 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from dalgwen as a code owner October 31, 2023 20:10
lolodomo
lolodomo approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

lolodomo commented Nov 3, 2023

@lsiepel : these fields were there but not used anywhere ? Because I see no change where they would be used.

@lsiepel
Copy link
Contributor Author

lsiepel commented Nov 3, 2023 •
edited
Loading

@lsiepel : these fields were there but not used anywhere ? Because I see no change where they would be used.

Yes, i came to the same conclusion. I guess the dto objects hold all properties, whether they are used or not.

@lolodomo lolodomo merged commit 7724f16 into openhab:main Nov 3, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Nov 3, 2023
@lsiepel lsiepel deleted the mycroft-gson branch November 3, 2023 21:23
@dalgwen
Copy link
Contributor

dalgwen commented Nov 4, 2023

Sorry for the late reply.

@lsiepel : these fields were there but not used anywhere ? Because I see no change where they would be used.

Yes, they are not used. You guessed right, I put all properties inside the DTO, "just in case".

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
@lsiepel @andrewfg
gson fields alias (openhab#15829)
19cfbcf 
Signed-off-by: Leo Siepel <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lsiepel @austvik
gson fields alias (openhab#15829)
4964a1c 
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@dalgwen dalgwen Awaiting requested review from dalgwen dalgwen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lsiepel @lolodomo @dalgwen