-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doorbird] Warning and SAT cleanup #15824
Conversation
Signed-off-by: Leo Siepel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the changes!
I had just a few comments.
...orbird/src/main/java/org/openhab/binding/doorbird/internal/listener/DoorbirdUdpListener.java
Outdated
Show resolved
Hide resolved
...ing.doorbird/src/main/java/org/openhab/binding/doorbird/internal/action/DoorbirdActions.java
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @jlaur, LGTM
...ng.doorbird/src/main/java/org/openhab/binding/doorbird/internal/handler/DoorbellHandler.java
Show resolved
Hide resolved
...ng.doorbird/src/main/java/org/openhab/binding/doorbird/internal/handler/DoorbellHandler.java
Show resolved
Hide resolved
...ing.doorbird/src/main/java/org/openhab/binding/doorbird/internal/action/DoorbirdActions.java
Outdated
Show resolved
Hide resolved
...ing.doorbird/src/main/java/org/openhab/binding/doorbird/internal/action/DoorbirdActions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
* Warning and SAT clenaup --------- Signed-off-by: Leo Siepel <[email protected]>
* Warning and SAT clenaup --------- Signed-off-by: Leo Siepel <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Added some local null checks to prevent warnings and a static var name fix.