Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doorbird] Warning and SAT cleanup #15824

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Oct 30, 2023

Added some local null checks to prevent warnings and a static var name fix.

Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from a team October 30, 2023 17:53
@lsiepel lsiepel requested a review from mhilbush as a code owner October 30, 2023 17:53
@lsiepel lsiepel changed the title [doorbird] Warning and SAT clenaup [doorbird] Warning and SAT cleanup Oct 30, 2023
Copy link
Contributor

@mhilbush mhilbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the changes!

I had just a few comments.

Signed-off-by: Leo Siepel <[email protected]>
Copy link
Contributor

@mhilbush mhilbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @jlaur, LGTM

Signed-off-by: Leo Siepel <[email protected]>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 6efa3d7 into openhab:main Nov 4, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Nov 4, 2023
@lsiepel lsiepel deleted the doorbird-cleanup branch November 4, 2023 10:14
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
* Warning and SAT clenaup

---------

Signed-off-by: Leo Siepel <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* Warning and SAT clenaup

---------

Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants