[twitter] rename binding to X

[lsiepel]

I guess X is here to stay for a while. This PR :

=> Renaming files, classes and documentation from Twitter to X.
=> Update twitter4j from 4.0.7 to 4.1.2

Changelogs:
https://twitter4j.org/2022/10/12/120
https://twitter4j.org/2022/10/21/264
https://twitter4j.org/2022/10/27/269

@computergeek1507 can you test this version?

Fixes #15370

[lsiepel]

Don't understand why the build is failing, might need some help.

[wborn]

I think you forgot to update the BOM:

openhab-addons/bom/openhab-addons/pom.xml

Line 1761 in 8bcbd45

<artifactId>org.openhab.binding.twitter</artifactId>

[lsiepel]

What can we do with the non-default translations files ? Is crowdin able to rename the files?

[lsiepel]

Need some help with the build error.

[wborn]

Message: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=openhab-binding-x; type=karaf.feature; version=4.1.0.SNAPSHOT; filter:="(&(osgi.identity=openhab-binding-x)(type=karaf.feature)(version>=4.1.0.SNAPSHOT))" [caused by: Unable to resolve openhab-binding-x/4.1.0.SNAPSHOT: missing requirement [openhab-binding-x/4.1.0.SNAPSHOT] osgi.identity; osgi.identity=org.openhab.binding.x; type=osgi.bundle; version="[4.1.0.202310280753,4.1.0.202310280753]"; resolution:=mandatory [caused by: Unable to resolve org.openhab.binding.x/4.1.0.202310280753: missing requirement [org.openhab.binding.x/4.1.0.202310280753] osgi.wiring.package; filter:="(osgi.wiring.package=org.slf4j.impl)"]]

It's most likely caused by the dependency upgrade of twitter4j-core. Bnd does bytecode analysis on the embedded classes to see which classes are imported. If the packages of the classes are not provided by the bundle itself, Bnd adds package imports to the generated bundle manifest. The Karaf feature validation checks if all package imports in the feature bundle manifests can be satisfied by the installed bundles.

So in this case there is no bundle providing org.slf4j.impl. This is due to bad design of twitter4j-core because it shouldn't depend on internal implementation classes as they have no stable APIs and the implementation of these classes can change between any release. We use Pax Logging which does provide the public (stable) SLF4J APIs but for these reasons not the internal (unstable) implementation classes.

You can probably workaround this by adding !org.slf4j.impl.* to the bnd.importpackage property in the POM but it could be that this breaks the twitter4j-core logging.

[wborn]

Thanks for addressing the comments! I have added a few more below:

[lsiepel]

Can we also do some smart renaming for the crowdin properties/files? Hope someone else picks up that task as i'm not familiair with crowdin.

[wborn]

Thanks! 👍

[wborn]

Can you also create a PR to add some info for these changes in update.lst in the distro repo @lsiepel ?