-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hue] Support new home security products (API v2) #15601
Conversation
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition of the new security products, LGTM.
Can you refresh my memory, what is the test status? Did you get any community feedback? IIRC you don't currently have any of the security products? In any case, if you are confident with the PR in its current state, let's merge it and await user feedback. 🙂
It works for me.
Nope.
Wrong. I purchased a security contact device for testing. It is not actually used daily in my system. But it does work for testing purposes. By contrast I did not purchase a security camera device, but it simply uses a DTO based on the regular motion sensor (which I do have), so I guess it is probably Ok.
Agreed. |
Many thanks @jlaur |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Philips / Signify has added a range of home security products to its offering. Specifically security cameras, security contact devices, and tamper switch devices. And this PR adds support for those products.
Resolves #15562
Signed-off-by: Andrew Fiddian-Green [email protected]