Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hue] Support new home security products (API v2) #15601

Merged
merged 8 commits into from
Nov 9, 2023

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Sep 15, 2023

Philips / Signify has added a range of home security products to its offering. Specifically security cameras, security contact devices, and tamper switch devices. And this PR adds support for those products.

Resolves #15562

Signed-off-by: Andrew Fiddian-Green [email protected]

@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged awaiting other PR Depends on another PR labels Sep 15, 2023
@andrewfg andrewfg requested a review from cweitkamp as a code owner September 15, 2023 17:16
@andrewfg andrewfg self-assigned this Sep 15, 2023
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg requested a review from jlaur September 15, 2023 18:42
@andrewfg andrewfg changed the title [hue] Add support for home security products [hue] Support new home security products Sep 15, 2023
@andrewfg andrewfg removed the work in progress A PR that is not yet ready to be merged label Oct 10, 2023
@andrewfg andrewfg removed the awaiting other PR Depends on another PR label Oct 27, 2023
@andrewfg
Copy link
Contributor Author

@jlaur since your #15552 has been merged, this one is also ready for review

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition of the new security products, LGTM.

Can you refresh my memory, what is the test status? Did you get any community feedback? IIRC you don't currently have any of the security products? In any case, if you are confident with the PR in its current state, let's merge it and await user feedback. 🙂

@andrewfg
Copy link
Contributor Author

andrewfg commented Nov 8, 2023

what is the test status?

It works for me.

Did you get any community feedback?

Nope.

you don't currently have any of the security products?

Wrong. I purchased a security contact device for testing. It is not actually used daily in my system. But it does work for testing purposes.

By contrast I did not purchase a security camera device, but it simply uses a DTO based on the regular motion sensor (which I do have), so I guess it is probably Ok.

if you are confident with the PR in its current state, let's merge it and await user feedback

Agreed.

@jlaur jlaur merged commit 4f6d33b into openhab:main Nov 9, 2023
@jlaur jlaur added this to the 4.1 milestone Nov 9, 2023
@andrewfg
Copy link
Contributor Author

andrewfg commented Nov 9, 2023

Many thanks @jlaur

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/hue-contact-sensor/151141/2

andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
@jlaur jlaur changed the title [hue] Support new home security products [hue] Support new home security products (API v2) Dec 3, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
@andrewfg andrewfg deleted the hue-security branch August 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hue] support new home security devices
3 participants