-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt.espmilighthub] Update README.md #15019
Conversation
Add "MQTT Client Status Messages Mode setting" to ESP Config.. Signed-off-by: hutcheonk <[email protected]>
LGTM.... Thanks for PR, hope you make many more as all contribs are welcome. |
@@ -45,6 +45,9 @@ Leave this blank. | |||
**MQTT Client Status Topic:** | |||
`milight/status` | |||
|
|||
**MQTT Client Status Messages Mode:** | |||
Simple. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's so simple that I don't understand it. What exactly needs to be set? Is "Simple" the option you have to choose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple
is the option you select from the box labelled MQTT Client Status Messages Mode: It makes sense when you look at the GUI of the device and the rest of the setup is formatted the same way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-N-K : is it ok for you now ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-N-K as above are you happy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As you have no feedback from @J-N-K since several weeks and the official maintainer of this binding is fine with the change, let's merge this PR. |
Add "MQTT Client Status Messages Mode setting" to ESP Config.. Signed-off-by: hutcheonk <[email protected]>
Add "MQTT Client Status Messages Mode setting" to ESP Config.. Signed-off-by: hutcheonk <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Add "MQTT Client Status Messages Mode setting" to ESP Config..