Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.espmilighthub] Update README.md #15019

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

hutcheonk
Copy link
Contributor

Add "MQTT Client Status Messages Mode setting" to ESP Config..

Add "MQTT Client Status Messages Mode setting" to ESP Config..

Signed-off-by: hutcheonk <[email protected]>
@hutcheonk hutcheonk requested a review from Skinah as a code owner May 23, 2023 07:50
@Skinah
Copy link
Contributor

Skinah commented May 23, 2023

LGTM.... Thanks for PR, hope you make many more as all contribs are welcome.

@Skinah Skinah changed the title Update README.md [] Update README.md May 23, 2023
@Skinah Skinah changed the title [] Update README.md [mqtt.espmilighthub] Update README.md May 23, 2023
@Skinah Skinah added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 24, 2023
@Skinah Skinah added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 2, 2023
@@ -45,6 +45,9 @@ Leave this blank.
**MQTT Client Status Topic:**
`milight/status`

**MQTT Client Status Messages Mode:**
Simple.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's so simple that I don't understand it. What exactly needs to be set? Is "Simple" the option you have to choose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple is the option you select from the box labelled MQTT Client Status Messages Mode: It makes sense when you look at the GUI of the device and the rest of the setup is formatted the same way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J-N-K : is it ok for you now ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J-N-K as above are you happy?

Copy link
Contributor

@Skinah Skinah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 13, 2023
@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 23, 2023
@Skinah Skinah added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 18, 2023
@lolodomo
Copy link
Contributor

As you have no feedback from @J-N-K since several weeks and the official maintainer of this binding is fine with the change, let's merge this PR.

@lolodomo lolodomo merged commit 97039d0 into openhab:main Nov 11, 2023
@lolodomo lolodomo added this to the 4.1 milestone Nov 11, 2023
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
Add "MQTT Client Status Messages Mode setting" to ESP Config..

Signed-off-by: hutcheonk <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Add "MQTT Client Status Messages Mode setting" to ESP Config..

Signed-off-by: hutcheonk <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants