[ecovacs] Allow loading device descriptions from a user file #14873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a new device is released within our release cycle, getting the description for that device into the binding was impossible for users before. With this change, they can create an override file in their installation (with contents we'll need to supply to them), which serves as a stop-gap solution until the next OH release. Signed-off-by: Danny Baumann <[email protected]>
Signed-off-by: Danny Baumann <[email protected]>
jlaur
requested changes
Apr 27, 2023
...ding.ecovacs/src/main/java/org/openhab/binding/ecovacs/internal/api/impl/EcovacsApiImpl.java
Outdated
Show resolved
Hide resolved
jlaur
added
enhancement
Signed-off-by: Danny Baumann <[email protected]>
Done, please let me know what you think of it. I've intentionally been a bit vague on the full JSON object format, because it's unlikely that a device list entry will be sufficient in case of completely new models. |
jlaur
reviewed
Apr 28, 2023
Signed-off-by: Danny Baumann <[email protected]>
jlaur
reviewed
Apr 29, 2023
jlaur
reviewed
Apr 29, 2023
Signed-off-by: Danny Baumann <[email protected]>
tb4jc
pushed a commit
to tb4jc/openhab-addons
that referenced
this pull request
Jun 19, 2023
…#14873) * [ecovacs] Allow loading device descriptions from a user file If a new device is released within our release cycle, getting the description for that device into the binding was impossible for users before. With this change, they can create an override file in their installation (with contents we'll need to supply to them), which serves as a stop-gap solution until the next OH release. Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Thomas Burri <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
…#14873) * [ecovacs] Allow loading device descriptions from a user file If a new device is released within our release cycle, getting the description for that device into the binding was impossible for users before. With this change, they can create an override file in their installation (with contents we'll need to supply to them), which serves as a stop-gap solution until the next OH release. Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Matt Myers <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…#14873) * [ecovacs] Allow loading device descriptions from a user file If a new device is released within our release cycle, getting the description for that device into the binding was impossible for users before. With this change, they can create an override file in their installation (with contents we'll need to supply to them), which serves as a stop-gap solution until the next OH release. Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new device is released within our release cycle, getting the description for that device into the binding was impossible for users before. With this change, they can create an override file in their installation (with contents we'll need to supply to them), which serves as a stop-gap solution until the next OH release.
Additionally, add the definition for the device that triggered this change to the supported device list.