Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump spotless to 2.35 and Eclipse Java Formatter to 4.26 #14645

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Bump spotless to 2.35 and Eclipse Java Formatter to 4.26 #14645

merged 1 commit into from
Mar 21, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Mar 21, 2023

ccutrer
ccutrer approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@ccutrer ccutrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Homekit and mqtt.homeassistant

jlaur
jlaur approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stefanroellin
Copy link
Contributor

LGTM for pilight

@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 21, 2023
@J-N-K
Copy link
Member Author

J-N-K commented Mar 21, 2023

Jenkins failed unrelated with a Wemo test, IMO this can be ignored.

mherwege
mherwege approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for elroconnects binding

@lsiepel
Copy link
Contributor

lsiepel commented Mar 21, 2023

Think it is spotless 2.35 and not 2.25. ?

@J-N-K J-N-K changed the title Bump spotless to 2.25 and Eclipse Java Formatter to 4.26 Bump spotless to 2.35 and Eclipse Java Formatter to 4.26 Mar 21, 2023
@jlaur jlaur merged commit 8e902f6 into openhab:main Mar 21, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 21, 2023
@morph166955
Copy link
Contributor

Will this change require new/pending bindings to rebase and update prior to review/merge?

@J-N-K J-N-K deleted the spotless branch March 21, 2023 21:09
@J-N-K
Copy link
Member Author

J-N-K commented Mar 21, 2023

Only those that are formatted differently by the two spotless versions. I guess you'll see if it's necessary when CI builds fail.

@morph166955
Copy link
Contributor

Thank you!

renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@J-N-K @renescherer
Bump spotless to 2.35 and Eclipse Java Formatter to 4.26 (openhab#14645)
d9b9f4f 
Signed-off-by: Jan N. Klug <[email protected]>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@J-N-K @FordPrfkt
Bump spotless to 2.35 and Eclipse Java Formatter to 4.26 (openhab#14645)
5881348 
Signed-off-by: Jan N. Klug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccutrer ccutrer ccutrer approved these changes

@jlaur jlaur jlaur approved these changes

@mherwege mherwege mherwege approved these changes

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

@yfre yfre Awaiting requested review from yfre yfre is a code owner

@gs4711 gs4711 Awaiting requested review from gs4711 gs4711 is a code owner

@andrewfg andrewfg Awaiting requested review from andrewfg andrewfg is a code owner

@octa22 octa22 Awaiting requested review from octa22 octa22 is a code owner

@msteigenberger msteigenberger Awaiting requested review from msteigenberger msteigenberger is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@stefanroellin stefanroellin Awaiting requested review from stefanroellin stefanroellin is a code owner

@niklasdoerfler niklasdoerfler Awaiting requested review from niklasdoerfler niklasdoerfler is a code owner

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

@antroids antroids Awaiting requested review from antroids antroids is a code owner

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@sprehn sprehn Awaiting requested review from sprehn sprehn is a code owner

@syphr42 syphr42 Awaiting requested review from syphr42 syphr42 is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@holgerfriedrich holgerfriedrich Awaiting requested review from holgerfriedrich holgerfriedrich is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@J-N-K @stefanroellin @lsiepel @morph166955 @ccutrer @jlaur @mherwege