Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[neato] Remove org.apache.common #14415

Merged
merged 2 commits into from
Feb 19, 2023
Merged

[neato] Remove org.apache.common #14415

merged 2 commits into from
Feb 19, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 17, 2023

  • Remove dependency on apache.commons

Untested, minor refactoring from only from code perspective

Signed-off-by: lsiepel <[email protected]>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 46f9d5e into openhab:main Feb 19, 2023
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 19, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 19, 2023
@lsiepel lsiepel deleted the neato-apache branch February 19, 2023 21:31
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants