Code

[siemenshvac] Initial contribution#14263

Code

Merged

jlaur merged 214 commits intoopenhab:mainopenhab/openhab-addons:mainfrom lo92fr:14262-siemensHvaclo92fr/openhab-addons:14262-siemensHvacCopy head branch name to clipboardJun 29, 2024

+7,087

Commits

Commits on Apr 3, 2024

• intial version

  Show description for f60dd67
  lo92fr

  committed
  f60dd67

• first working 3.x versions

  Show description for 17000f7
  lo92fr

  committed
  17000f7

• better menu handing

  Show description for 77c268d
  lo92fr

  committed
  77c268d

• move to 3.2.0

  Show description for 755b570
  lo92fr

  committed
  755b570

• code cleanup, review nullable annotations

  Show description for faa0df6
  lo92fr

  committed
  faa0df6

• some discovery fixes

  Show description for 780d5b0
  lo92fr

  committed
  780d5b0

• fix spotless violations

  Show description for 874d983
  lo92fr

  committed
  874d983

• review warnings

  Show description for bdf2d7b
  lo92fr

  committed
  bdf2d7b

• fix pmd errors and exceptions

  Show description for ea5745e
  lo92fr

  committed
  ea5745e

• review warnings

  Show description for 70dc554
  lo92fr

  committed
  70dc554

• review handling of value updates

  Show description for cc54684
  lo92fr

  committed
  cc54684

• review logger params

  Show description for 98d657a
  lo92fr

  committed
  98d657a

• review handleCommand code

  Show description for 5a30462
  lo92fr

  committed
  5a30462

• review initialization and error handling

  Show description for 0d83e53
  lo92fr

  committed
  0d83e53

• apply spotless

  Show description for 2b90a2d
  lo92fr

  committed
  2b90a2d

• update resource file to new format

  Show description for 22e1243
  lo92fr

  committed
  22e1243

• add more information during init phase

  Show description for e65e7af
  lo92fr

  committed
  e65e7af

• fix bad map key

  Show description for 7996018
  lo92fr

  committed
  7996018

• review id Handling on handleCommand

  Show description for 70f493c
  lo92fr

  committed
  70f493c

• review logging

  Show description for 3caacec
  lo92fr

  committed
  3caacec

• review authentification

  Show description for 9785be7
  lo92fr

  committed
  9785be7

• spotless:aply

  Show description for a1fa41a
  lo92fr

  committed
  a1fa41a

• fix logger

  Show description for f6e3900
  lo92fr

  committed
  f6e3900

• add siemenshvac to parent pom

  Show description for d640c25
  lo92fr

  committed
  d640c25

• first pass correction on pull request comments

  Show description for 2aa4313
  lo92fr

  committed
  2aa4313

• fix character conversions

  Show description for 02b9c52
  lo92fr

  committed
  02b9c52

• add Readme files

  Show description for c54e2a9
  lo92fr

  committed
  c54e2a9

• fix List.of()

  Show description for bf9e646
  lo92fr

  committed
  bf9e646

• fix other comments

  Show description for a453a51
  lo92fr

  committed
  a453a51

• fix a typo on README.md

  Show description for ca9ec4f
  lo92fr

  committed
  ca9ec4f

• try to fix pull request build errors !

  Show description for 43c8267
  lo92fr

  committed
  43c8267

• fix indentations

  Show description for af23bad
  lo92fr

  committed
  af23bad

• fix internationalization files

  Show description for 8d5692b
  lo92fr

  committed
  8d5692b

• fixes for 2nd review

  Show description for b1ab1b3
  lo92fr

  committed
  b1ab1b3

• spotless:apply

  Show description for 7ab5f1a
  lo92fr

  committed
  7ab5f1a

• fix typo

  Show description for 4a588c7
  lo92fr

  committed
  4a588c7

• better type initialization : only 1 type registered for basic types

  Show description for a6ff40f
  lo92fr

  committed
  a6ff40f

• use channelTypeRegistry for getting type

  Show description for 7e8cf1e
  lo92fr

  committed
  7e8cf1e

• review generation of ChannelType UUID

  Show description for 1fd8aa5
  lo92fr

  committed
  1fd8aa5

• add binding range basic default type in case of initialization from files without discovery

  Show description for c4a71c1
  lo92fr

  committed
  c4a71c1

• add documentation and samples

  Show description for 7f8e63f
  lo92fr

  committed
  7f8e63f

• spotless:apply

  Show description for d4a5353
  lo92fr

  committed
  d4a5353

• change log level

  Show description for 68fafb5
  lo92fr

  committed
  68fafb5

• add constraint control from state on numeric before writing values

  Show description for cfa3eb1
  lo92fr

  committed
  cfa3eb1

• spotless:apply

  Show description for 34c30d4
  lo92fr

  committed
  34c30d4

• remove logs

  Show description for 7c84e72
  lo92fr

  committed
  7c84e72

• spotless:apply

  Show description for 9348fe6
  lo92fr

  committed
  9348fe6

• review write request load

  Show description for 2883c73
  lo92fr

  committed
  2883c73

• fix enum

  Show description for f4f30cb
  lo92fr

  committed
  f4f30cb

• Update bundles/org.openhab.binding.siemenshvac/pom.xml

  Show description for f76601c
  

  lo92fr

  and

  wborn

  committed
  f76601c

• First pass on jlaur review

  Show description for 9ce7efe
  lo92fr

  committed
  9ce7efe

• running spotless:apply

  Show description for 624c27d
  lo92fr

  committed
  624c27d

• remove deprecated call

  Show description for 5ed68a2
  lo92fr

  committed
  5ed68a2

• pass on jlaur review

  Show description for 4b128c2
  lo92fr

  committed
  4b128c2

• fix pom (jlaur review)

  Show description for a61dd36
  lo92fr

  committed
  a61dd36

• fix bad state handling for Enumeration

  Show description for 7045d5f
  lo92fr

  committed
  7045d5f

• fix enumeration underlying type

  Show description for 32edb71
  lo92fr

  committed
  32edb71

• review metadata reading to handle localization more properly and get english label

  Show description for f46a6f0
  lo92fr

  committed
  f46a6f0

• remove comment on cache loading

  Show description for 8b46c04
  lo92fr

  committed
  8b46c04

• fix bad flow on HTML request

  Show description for e4845e3
  lo92fr

  committed
  e4845e3

• add comment about timeout

  Show description for 10e043b
  lo92fr

  committed
  10e043b

• add Metadata/SiemensHvacMetadataLanguage.java add Metadata/SiemensHvacMetadataUser.java class

  Show description for a13c8bb
  lo92fr

  committed
  a13c8bb

• review channel type handling :

  Show description for 2cfec58
  lo92fr

  committed
  2cfec58

• spotless::apply

  Show description for 00067b7
  lo92fr

  committed
  00067b7

• fix build errors

  Show description for dcd979f
  lo92fr

  committed
  dcd979f

• fix build errors

  Show description for 550b571
  lo92fr

  committed
  550b571

• spotless:apply

  Show description for a82ef01
  lo92fr

  committed
  a82ef01

• review concurrency on SiemensHvacHandlerImpl

  Show description for d1b5750
  lo92fr

  committed
  d1b5750

• fix advanced channel handling

  Show description for 8ef0f56
  lo92fr

  committed
  8ef0f56

• fix typo on label

  Show description for c16c6dd
  lo92fr

  committed
  c16c6dd

• remove public on getInternalConfigDescription

  Show description for 9e37118
  lo92fr

  committed
  9e37118

• remove unnecessary ChannelTypeRegistry

  Show description for 3a2432d
  lo92fr

  committed
  3a2432d

• remove public on addChannelType

  Show description for e681f88
  lo92fr

  committed
  e681f88

• remove unnecessary public

  Show description for 4fcefa2
  lo92fr

  committed
  4fcefa2

• fix some typo in README.md

  Show description for 3460285
  lo92fr

  committed
  3460285

• review some typos in files

  Show description for 81627e7
  lo92fr

  committed
  81627e7

• fix translations and type on thing file

  Show description for eb84c90
  lo92fr

  committed
  eb84c90

• mvn spotless:apply

  Show description for 2eb8990
  lo92fr

  committed
  2eb8990

• fix package naming conventions: Metadata

  Show description for 89663c1
  lo92fr

  committed
  89663c1

• review coding style rules

  Show description for 8ace723
  lo92fr

  committed
  8ace723

• review coding rules

  Show description for 3d58887
  lo92fr

  committed
  3d58887

• fix coding rules

  Show description for 8acf42e
  lo92fr

  committed
  8acf42e

• Delete bundles/org.openhab.binding.siemenshvac/src/main/java/org/openhab/binding/siemenshvac/internal/Metadata directory

  Show description for 30309ef
  lo92fr

  committed
  30309ef

• fix typo

  Show description for a1a8537
  lo92fr

  committed
  a1a8537

• fix Diagram path

  Show description for 01ccf99
  lo92fr

  committed
  01ccf99

• replace loop by Normalizer to sanetize UID

  Show description for 49aac2e
  lo92fr

  committed
  49aac2e

• fix missing filter in UidUtils

  Show description for 7bb99ef
  lo92fr

  committed
  7bb99ef

• jlaur review : remove duplicate entry

  Show description for 239e2d2
  lo92fr

  committed
  239e2d2

• jlaur review : remove @disabled annotation on test

  Show description for cd5c35f
  lo92fr

  committed
  cd5c35f

• remove extra public keywords

  Show description for ebf1bff
  lo92fr

  committed
  ebf1bff

• review clinique : commit some missing fixes

  Show description for ae336f6
  lo92fr

  committed
  ae336f6

• fix typo in pom.xml

  Show description for c715c7b
  lo92fr

  committed
  c715c7b

• remove empty line on SiemensHvacHandlerImpl.java

  Show description for 3fdd6e6
  lo92fr

  committed
  3fdd6e6

• jlaur review : fix two null warning on SiemensHvacMetadataRegistryImpl.java

  Show description for 79d6b9d
  lo92fr

  committed
  79d6b9d

• fix addon.xml headers

  Show description for c036cb4
  lo92fr

  committed
  c036cb4

• fix another nullable warning on MetdataMenu

  Show description for 09066c2
  lo92fr

  committed
  09066c2

• fix account handling when we are using end user account to connect to the gateway

  Show description for f2b81df
  lo92fr

  committed
  f2b81df

• fix possible invalid '+' characters in id

  Show description for 10ffbcb
  lo92fr

  committed
  10ffbcb

• add some verification mechanism on baseUrl format

  Show description for efd2a06
  lo92fr

  committed
  efd2a06

• mvn spotless:apply

  Show description for 4d47e6c
  lo92fr

  committed
  4d47e6c

• fix error on handling session expiration

  Show description for 5f174ee
  lo92fr

  committed
  5f174ee

• Complete review of binding code :

  Show description for 62308d7
  lo92fr

  committed
  62308d7

• spotless:apply

  Show description for b58e7fe
  lo92fr

  committed
  b58e7fe

• fix error in build

  Show description for 46584ca
  lo92fr

  committed
  46584ca

• fix some checkstyles warnings

  Show description for 5b6eda0
  lo92fr

  committed
  5b6eda0

• add a stale request verification mechanism

  Show description for 5b7564a
  lo92fr

  committed
  5b7564a

• fix possible specific value return by gateway for DecimalType when no value available

  Show description for 0b8a97a
  lo92fr

  committed
  0b8a97a

• add build date to log to see which version is running

  Show description for eb442f4
  lo92fr

  committed
  eb442f4

• review debuging info on StaleRequest checker

  Show description for fe3ad67
  lo92fr

  committed
  fe3ad67

• move readChannel loging to prevent log flood

  Show description for 19e5db2
  lo92fr

  committed
  19e5db2

• rename initialization methods

  Show description for 079f37b
  lo92fr

  committed
  079f37b

• review timeout handling

  Show description for b6fb4fb
  lo92fr

  committed
  b6fb4fb

• add invalidation methods on provider to enable reinit of the addon

  Show description for 2523aa5
  lo92fr

  committed
  2523aa5

• update pom version

  Show description for fff9ba8
  lo92fr

  committed
  fff9ba8

• fix error on stale request handling

  Show description for fd3b6bf
  lo92fr

  committed
  fd3b6bf

• fix README.md as request by @jlaur

  Show description for a1c989a
  lo92fr

  committed
  a1c989a

• fix bad author in comments

  Show description for 6507097
  lo92fr

  committed
  6507097

• fix homematic reference in comments !

  Show description for 1d58cf5
  lo92fr

  committed
  1d58cf5

• fix exception handling

  Show description for 83ff9a8
  lo92fr

  committed
  83ff9a8

• fix duration intermediate variable

  Show description for 715f9cf
  lo92fr

  committed
  715f9cf

• fix some logging statement from info to trace

  Show description for 8f3ab58
  lo92fr

  committed
  8f3ab58

• fix some typo

  Show description for 084b7b4
  lo92fr

  committed
  084b7b4

• fix initializer

  Show description for 045d98a
  lo92fr

  committed
  045d98a

• fix some status update

  Show description for 0c5efd8
  lo92fr

  committed
  0c5efd8

• remove some unneed code

  Show description for 8390762
  lo92fr

  committed
  8390762

• fix map intialization

  Show description for ca46b78
  lo92fr

  committed
  ca46b78

• fix location on readme

  Show description for f60e35d
  lo92fr

  committed
  f60e35d

• fix comment

  Show description for 54d97ac
  lo92fr

  committed
  54d97ac

• fix header comments !

  Show description for fb21318
  lo92fr

  committed
  fb21318

• fix some compilations errors

  Show description for 7b49e4d
  lo92fr

  committed
  7b49e4d

• remove unused method displayRequestStats()

  Show description for 5c8cd17
  lo92fr

  committed
  5c8cd17

• fix exception handling

  Show description for 5bf50c3
  lo92fr

  committed
  5bf50c3

• review exception logging

  Show description for 5378d6f
  lo92fr

  committed
  5378d6f

• removed unused ovveride

  Show description for 31f34b0
  lo92fr

  committed
  31f34b0

• remove password logging in case of exception

  Show description for f8d9f4a
  lo92fr

  committed
  f8d9f4a

• fix concurrent hashmap access

  Show description for 20e8373
  lo92fr

  committed
  20e8373

• mvn spotless:apply

  Show description for 5c888a5
  lo92fr

  committed
  5c888a5

• fix unbalanced locking request

  Show description for 3904aba
  lo92fr

  committed
  3904aba

• review error handling on gateway after new bug reporting from Vasek:

  Show description for e293f61
  lo92fr

  committed
  e293f61

• fix logger.debug clause

  Show description for bb240a3
  lo92fr

  committed
  bb240a3

• fix logger.debug clause

  Show description for 166bfce
  lo92fr

  committed
  166bfce

• fix some checkStyle warnings

  Show description for 27c0aae
  lo92fr

  committed
  27c0aae

• capitalized Hvac

  Show description for 1f92ceb
  lo92fr

  committed
  1f92ceb

• review type conversion handling between siemens and openhab type (WIP)

  Show description for ae6c879
  lo92fr

  committed
  ae6c879

• review type conversion handling between siemens and openhab type (WIP)

  Show description for 8c634a6
  lo92fr

  committed
  8c634a6

Commits on Apr 4, 2024

• review type conversion handling between siemens and openhab type

  Show description for 70c8858
  lo92fr

  committed
  70c8858

• review type conversion handling between siemens and openhab type

  Show description for 73f058c
  lo92fr

  committed
  73f058c

• review type conversion handling between siemens and openhab type

  Show description for b6c9f0e
  lo92fr

  committed
  b6c9f0e

Commits on Apr 14, 2024

• fix contact handling (WIP)

  Show description for 027af65
  lo92fr

  committed
  027af65

• fix contact handling (WIP)

  Show description for 5de868a
  lo92fr

  committed
  5de868a

• fix contact handling (WIP)

  Show description for 1647bae
  lo92fr

  committed
  1647bae

• fix contact handling (WIP)

  Show description for 39d4d86
  lo92fr

  committed
  39d4d86

Commits on Apr 16, 2024

• fix state description on Radiobutton

  Show description for dad40e0
  lo92fr

  committed
  dad40e0

Commits on Apr 30, 2024

• fix unregisterRequestHandler to unregister handler only once

  Show description for 0613800
  lo92fr

  committed
  0613800

Commits on May 6, 2024

• div fixes for last jlaur review

  Show description for 61cd02b
  lo92fr

  committed
  61cd02b

• review checkstyle warnings

  Show description for 101f6da
  lo92fr

  committed
  101f6da

• remove normalizer

  Show description for d9a8742
  lo92fr

  committed
  d9a8742

• put back normalizer because unit testing fail because of accent handling

  Show description for e5d6b53
  lo92fr

  committed
  e5d6b53

• put back normalizer because unit testing fail because of accent handling

  Show description for 1da0fd7
  lo92fr

  committed
  1da0fd7

Commits on May 7, 2024

• fixes for last jlaur review

  Show description for d007a84
  lo92fr

  committed
  d007a84

• fix CI error

  Show description for a237d99
  lo92fr

  committed
  a237d99

• spotless:apply

  Show description for 82eb3bf
  lo92fr

  committed
  82eb3bf

• fix CI error

  Show description for a2fc00b
  lo92fr

  committed
  a2fc00b

• fix CI errors

  Show description for 74e5340
  lo92fr

  committed
  74e5340

• fix CI errors

  Show description for 9fd33f8
  lo92fr

  committed
  9fd33f8

• add autodiscovering feature

  Show description for 6fa6aae
  lo92fr

  committed
  6fa6aae

Commits on May 14, 2024

• spotless:apply

  Show description for 0fbec96
  lo92fr

  committed
  0fbec96

• div fixes based on last JLaur review

  Show description for 0c3c6a7
  lo92fr

  committed
  0c3c6a7

• fix unit test

  Show description for bcdfa37
  lo92fr

  committed
  bcdfa37

• fix code violations

  Show description for 5c1d1a6
  lo92fr

  committed
  5c1d1a6

• review upnp discovery

  Show description for 907373f
  lo92fr

  committed
  907373f

• fix autodiscovery

  Show description for b0957b7
  lo92fr

  committed
  b0957b7

• change json cache file location

  Show description for 088cf37
  lo92fr

  committed
  088cf37

Commits on May 31, 2024

• first pass on May 15 review from Jacob

  Show description for defe62a
  lo92fr

  committed
  defe62a

• fix some imprecision on gateway model handle by the addon

  Show description for 06ce157
  lo92fr

  committed
  06ce157

Commits on Jun 2, 2024

• Add support for UoM

  Show description for 7424dee
  lo92fr

  committed
  7424dee

• review style checker warnings

  Show description for 76d5caa
  lo92fr

  committed
  76d5caa

• fix typo

  Show description for 9b52226
  lo92fr

  committed
  9b52226

Commits on Jun 3, 2024

• few typo fixes on last jlaur review

  Show description for a5455ef
  lo92fr

  committed
  a5455ef

• generalized bridge naming

  Show description for 8f78df2
  lo92fr

  committed
  8f78df2

• spotless:²apply

  Show description for 6bb1165
  lo92fr

  committed
  6bb1165

Commits on Jun 13, 2024

• progress on last jlaur review

  Show description for 5dc4d08
  lo92fr

  committed
  5dc4d08

• review binding addon.xml

  Show description for c6a437f
  lo92fr

  committed
  c6a437f

• fix unit test

  Show description for 6c6d2a0
  lo92fr

  committed
  6c6d2a0

• fix checkstyle errors

  Show description for aa63fa1
  lo92fr

  committed
  aa63fa1

• progress on last jlaur review

  Show description for 4fe620c
  lo92fr

  committed
  4fe620c

• remove specific device bridge

  Show description for 2242d69
  lo92fr

  committed
  2242d69

• remove unless samples

  Show description for bae833f
  lo92fr

  committed
  bae833f

• remove unless samples

  Show description for 04a45e8
  lo92fr

  committed
  04a45e8

Commits on Jun 14, 2024

• try to implements TemperatureChangeRate (WIP)

  Show description for ccc662e
  lo92fr

  committed
  ccc662e

• try to implements TemperatureChangeRate (WIP)

  Show description for 364b5b0
  lo92fr

  committed
  364b5b0

• try to implements TemperatureChangeRate (WIP)

  Show description for a14c669
  lo92fr

  committed
  a14c669

• spotless:apply

  Show description for 57269e1
  lo92fr

  committed
  57269e1

• fix translation on units

  Show description for 1ec0ff9
  lo92fr

  committed
  1ec0ff9

Commits on Jun 15, 2024

• move thirdparty folder

  Show description for 8dd9f34
  lo92fr

  committed
  8dd9f34

• modify pom for 3rd party

  Show description for f9bd544
  lo92fr

  committed
  f9bd544

• fix error in pom.xml

  Show description for 38a22ab
  lo92fr

  committed
  38a22ab

• spotless:apply

  Show description for 740d821
  lo92fr

  committed
  740d821

Commits on Jun 16, 2024

• continue on last @jlaur review

  Show description for 7469706
  lo92fr

  committed
  7469706

• fix error message on gateway init

  Show description for 9567b69
  lo92fr

  committed
  9567b69

Commits on Jun 18, 2024

• reintroduce serial in ThingUID when using discovery

  Show description for c09798c
  lo92fr

  committed
  c09798c

• add the serialNumber to the ozw thingUid

  Show description for 818083c
  lo92fr

  committed
  818083c

• review samples definition in README.md

  Show description for 5fbc435
  lo92fr

  committed
  5fbc435

• handle °C*min as simple number for now

  Show description for 91c9848
  lo92fr

  committed
  91c9848

• remove unuseful logger

  Show description for 1440993
  lo92fr

  committed
  1440993

• fix alignement in Reamdme.md

  Show description for bcaaad5
  lo92fr

  committed
  bcaaad5

Commits on Jun 25, 2024

• fix 3rdparty path

  Show description for 023bcfe
  lo92fr

  committed
  023bcfe

• fix uid convention

  Show description for 6a765f1
  lo92fr

  committed
  6a765f1

• move TimeOfDayTypeConverter to Number:Time representation

  Show description for d4308a6
  lo92fr

  committed
  d4308a6

• remove useless code in createThing

  Show description for 4494551
  lo92fr

  committed
  4494551

• spotless:apply

  Show description for 06b7437
  lo92fr

  committed
  06b7437

• spotless:apply

  Show description for 5366b24
  lo92fr

  committed
  5366b24

Commits on Jun 28, 2024

• some fixes from last @jlaur review

  Show description for 956b716
  lo92fr

  committed
  956b716

Commits on Jun 29, 2024

• fix a few readme.md issue and others

  Show description for 5ab5bb4
  lo92fr

  committed
  5ab5bb4