-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bluetooth.bluez] null annotations and checkstyle #13980
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,7 @@ public DeviceManagerWrapper(@Nullable DeviceManager deviceManager) { | |
this.deviceManager = deviceManager; | ||
} | ||
|
||
@SuppressWarnings("null") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it necessary to hide warnings? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, define necesary :-) It is needed because it is a So it is only needede to satisfy the compiler, on runtime it won't matter. |
||
public synchronized Collection<BluetoothAdapter> scanForBluetoothAdapters() { | ||
if (deviceManager != null) { | ||
return deviceManager.scanForBluetoothAdapters(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you do not want to rather check that exceptionMessage is not null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because it falls thru immediate and prevents the second part
equals
to throw an NPE.If you remove it, the compiler will throw a warning. And the debug format method handles the null fine.