-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bigassfan] Add null annotations #13903
Conversation
Signed-off-by: Leo Siepel <[email protected]>
...rc/main/java/org/openhab/binding/bigassfan/internal/discovery/BigAssFanDiscoveryService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring. I have provided some feedback.
....bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/BigAssFanHandlerFactory.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/openhab/binding/bigassfan/internal/discovery/BigAssFanDiscoveryService.java
Show resolved
Hide resolved
...rc/main/java/org/openhab/binding/bigassfan/internal/discovery/BigAssFanDiscoveryService.java
Show resolved
Hide resolved
...rc/main/java/org/openhab/binding/bigassfan/internal/discovery/BigAssFanDiscoveryService.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/openhab/binding/bigassfan/internal/discovery/BigAssFanDiscoveryService.java
Outdated
Show resolved
Hide resolved
...bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/handler/BigAssFanHandler.java
Outdated
Show resolved
Hide resolved
...bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/handler/BigAssFanHandler.java
Outdated
Show resolved
Hide resolved
...bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/utils/BigAssFanConverter.java
Outdated
Show resolved
Hide resolved
...bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/utils/BigAssFanConverter.java
Outdated
Show resolved
Hide resolved
...bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/utils/BigAssFanConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
...bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/handler/BigAssFanHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
All comments have been adressed, thanks. |
So just one final confirmation - since not labelled "additional testing preferred", I assume you have given it a good spin yourself 🙂? @mhilbush, you are code owner, would you like to have a look before merging? |
No i don't have this device, it is just from technicall code perspective. As it isn't that super complex, i'm confident we dont have any regressions like the bosesoundtouch. Yeah, i learned from that ;-) Also with 4.0 release far away any regressions can be fixed on time before a release, and besides snapshots being unstable at the moment i would not count on anyone testing at the moment. I leave it to you or @mhilbush |
We usually assume that the code has been tested, so thanks for the honesty here. My general advise would be in line with @fwolter's here: #14023 (comment). Although I agree that the risk is low, there is a real non-zero risk of breaking something which worked fine (and was tested by many users) without null annotations. See for example #13895 (comment). With ~200 lines changed, we both could have missed something. I recently also did this in #14010 with less confidence, even though just two lines changed, but in this case we had more to win than we had to lose. Summing up, my general advise would be to prioritize bindings which you can either test yourself, or with backup from someone who can test. If untested, please clearly state this in the description and also use the label "Additional testing preferred". This can give a hint to reviewers to take more care, and could also trigger some coordination to possibly have someone help testing it. Yet, here we are. I don't see any problems which were not already mentioned, but would like input from @mhilbush. If the JAR is up-to-date, perhaps we can look for a tester in previous PR's/issues for this binding or in the community? Sorry for being overly cautious, but better safe than sorry. 😄 I don't think we need to rush it. |
I understand your position and do take your and fwolter's advice serieus.. Couple of weeks ago i started to fix SAT issues to get to know more about openHAB's ecosystem and be of any value. And as you might have seen, after some of those PR's i stopped and switched to bugs/enhancements. While this and some PR's where allready there, i hope they are of added value and get merged and if not so be it. |
Yes, I'd like to look it over. And I'd like to actually run it for a while
in my environment where I have 3 of these fans.
I'm sorry I haven't been available to review this. Lots going on in 2022
that took much of my time. That will change in 2023.
…On January 2, 2023 3:41:41 PM Jacob Laursen ***@***.***> wrote:
All comments have been adressed, thanks.
So just one final confirmation - since not labelled "additional testing
preferred", I assume you have given it a good spin yourself 🙂?
@mhilbush, you are code owner, would you like to have a look before merging?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
So if you could hold off on merging I would appreciate it. |
@jlaur Thank you for the time you invested in the review so far. |
Built and installed the binding, and the handlers won't start.
|
....binding.bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/BigAssFanConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
Thanks. Handlers have started successfully. I will continue to run for a while in my environment. |
....binding.bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/BigAssFanConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have a few comments. Might have some more when I do a second pass.
....bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/BigAssFanHandlerFactory.java
Outdated
Show resolved
Hide resolved
....bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/BigAssFanHandlerFactory.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/openhab/binding/bigassfan/internal/discovery/BigAssFanDiscoveryService.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/openhab/binding/bigassfan/internal/discovery/BigAssFanDiscoveryService.java
Outdated
Show resolved
Hide resolved
...bigassfan/src/main/java/org/openhab/binding/bigassfan/internal/handler/BigAssFanHandler.java
Show resolved
Hide resolved
Signed-off-by: lsiepel <[email protected]>
Signed-off-by: lsiepel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been running well for me. And I don't have any other changes or comments. Therefore I'm good with merging.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Null annotations and some refactoring * Fix synchronized block * Fix remaining warnings Signed-off-by: Leo Siepel <[email protected]>
* Null annotations and some refactoring * Fix synchronized block * Fix remaining warnings Signed-off-by: Leo Siepel <[email protected]>
* Null annotations and some refactoring * Fix synchronized block * Fix remaining warnings Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel [email protected]
Changes:
added null annotations,
minor refactoring
fixed all SAT warnings
Edit: 4.0.0 JAR is available here: https://1drv.ms/u/s!AnMcxmvEeupwjp4Kbj6wM5O_dnnDew?e=z2G4qO