-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homematic] Fix min/max values for rollershutters #13821
Conversation
@MHerbst Mind having a look at this? |
For dimmers, the 1.0 max value sent by CCU was already converted to percent values in the item state description. Do the same thing also for roller shutters. Signed-off-by: Danny Baumann <[email protected]>
ac59bf2
to
3e16bea
Compare
Signed-off-by: Danny Baumann <[email protected]>
3e16bea
to
d7d6042
Compare
@maniac103 I know from the past of different problems with blinds and dimmers. I could never test with these devices myself, and therefore I can't judge whether any of your changes may have a negative side effect. |
I just remembered I also have a dimmer lying around, will do another test with that one tomorrow. No HMIP devices here though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
@maniac103 : shall I wait for you test before merging ? |
@lolodomo I think it should be fine to merge. Just tested state description output with a roller shutter:
and a dimmer:
and output looks as expected in both cases now. |
* [homematic] Fix min/max values for rollershutters For dimmers, the 1.0 max value sent by CCU was already converted to percent values in the item state description. Do the same thing also for roller shutters. Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Ben Rosenblum <[email protected]>
* [homematic] Fix min/max values for rollershutters For dimmers, the 1.0 max value sent by CCU was already converted to percent values in the item state description. Do the same thing also for roller shutters. Signed-off-by: Danny Baumann <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
* [homematic] Fix min/max values for rollershutters For dimmers, the 1.0 max value sent by CCU was already converted to percent values in the item state description. Do the same thing also for roller shutters. Signed-off-by: Danny Baumann <[email protected]>
* [homematic] Fix min/max values for rollershutters For dimmers, the 1.0 max value sent by CCU was already converted to percent values in the item state description. Do the same thing also for roller shutters. Signed-off-by: Danny Baumann <[email protected]>
* [homematic] Fix min/max values for rollershutters For dimmers, the 1.0 max value sent by CCU was already converted to percent values in the item state description. Do the same thing also for roller shutters. Signed-off-by: Danny Baumann <[email protected]>
For dimmers, the 1.0 max value sent by CCU was already converted to percent values in the item state description. Do the same thing also for roller shutters.
Previously, the item state description looked e.g. like this:
... which is obviously wrong. Both
ITEM_DIMMER
andITEM_ROLLERSHUTTER
usePercentTypeConverter
when converting item commands to CCU values, which is dividing the value by 100, so in both cases the maximum value in the state description should look the same.