Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonos] Unit tests added for OPML request parsing #13245

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from kgoderis as a code owner August 11, 2022 10:00
@lolodomo lolodomo added the test label Aug 11, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now just quick comment about usage of mockito-inline.

bundles/org.openhab.binding.sonos/pom.xml Outdated Show resolved Hide resolved
Fix a typo in previous unit tests

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo force-pushed the sonos_unit_test_OPML branch from ab0ddab to 9a56932 Compare August 11, 2022 13:15
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit f795f87 into openhab:main Aug 11, 2022
@jlaur jlaur added this to the 3.4 milestone Aug 11, 2022
@lolodomo lolodomo deleted the sonos_unit_test_OPML branch August 11, 2022 19:30
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Fix a typo in previous unit tests

Signed-off-by: Laurent Garnier <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Fix a typo in previous unit tests

Signed-off-by: Laurent Garnier <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Fix a typo in previous unit tests

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Fix a typo in previous unit tests

Signed-off-by: Laurent Garnier <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Fix a typo in previous unit tests

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants