Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hdpowerview] Fix output to console from tests and eliminate warnings #12824

Merged
merged 2 commits into from
Jun 4, 2022
Merged

[hdpowerview] Fix output to console from tests and eliminate warnings #12824

merged 2 commits into from
Jun 4, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 27, 2022 •
edited
Loading

This pull request contains two test improvements, each committed separately:

*: The output looked like this:

[INFO] Running org.openhab.binding.hdpowerview.AutomationChannelBuilderTest
[main] WARN  o.o.b.h.i.b.AutomationChannelBuilder - Scheduled event '1' references scene '1', but no scenes are loaded
[main] WARN  o.o.b.h.i.b.AutomationChannelBuilder - Scheduled event '1' references scene collection '2', but no scene collections are loaded

jlaur added 2 commits May 27, 2022 11:45
@jlaur
Avoid logging to console
234d3b9 
Signed-off-by: Jacob Laursen <[email protected]>
@jlaur
Fix redundant null checks
d6fb93c 
Signed-off-by: Jacob Laursen <[email protected]>
@jlaur jlaur added the test label May 27, 2022
@jlaur jlaur requested a review from J-N-K May 27, 2022 10:29
@jlaur jlaur changed the title [hdpowerview] Improve tests: Output to console and warnings [hdpowerview] Tests: Fix output to console and warnings May 27, 2022
@jlaur jlaur requested a review from a team May 27, 2022 18:57
@jlaur jlaur mentioned this pull request May 29, 2022
Merged
andrewfg
andrewfg approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur changed the title [hdpowerview] Tests: Fix output to console and warnings [hdpowerview] Fix output to console from tests and eliminate warnings Jun 3, 2022
lolodomo
lolodomo approved these changes Jun 4, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit f986183 into openhab:main Jun 4, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jun 4, 2022
@jlaur jlaur deleted the 11853-hdpowerview-improve-tests branch June 13, 2022 20:57
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@jlaur @leifbladt
[hdpowerview] Fix output to console from tests and eliminate warnings (…
3433b91 
…openhab#12824)

* Avoid logging to console
* Fix redundant null checks

Signed-off-by: Jacob Laursen <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@jlaur @andan67
[hdpowerview] Fix output to console from tests and eliminate warnings (…
75f8b91 
…openhab#12824)

* Avoid logging to console
* Fix redundant null checks

Signed-off-by: Jacob Laursen <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@jlaur @andrasU
[hdpowerview] Fix output to console from tests and eliminate warnings (…
1fd03dd 
…openhab#12824)

* Avoid logging to console
* Fix redundant null checks

Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
@jlaur jlaur mentioned this pull request Dec 9, 2022
Merged
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@jlaur @psmedley
[hdpowerview] Fix output to console from tests and eliminate warnings (…
c00e918 
…openhab#12824)

* Avoid logging to console
* Fix redundant null checks

Signed-off-by: Jacob Laursen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@andrewfg andrewfg andrewfg approved these changes

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jlaur @andrewfg @lolodomo