[plugwiseha] Improve cache and timeout handling #12345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <[email protected]>
…openhab-addons into plugwiseha-connectivity
|
One second i thought this was some kind of demo github page, but for real i have PR #12345 :-) |
lolodomo
requested changes
Feb 22, 2022
...main/java/org/openhab/binding/plugwiseha/internal/api/model/PlugwiseHAControllerRequest.java
Show resolved
Hide resolved
lolodomo
added
the
enhancement
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/plugwise-home-automation-binding-for-openhab/81299/136 |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* Rework caching and timeout handling * Fix another caching related issue Signed-off-by: Leo Siepel <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
* Rework caching and timeout handling * Fix another caching related issue Signed-off-by: Leo Siepel <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Rework caching and timeout handling * Fix another caching related issue Signed-off-by: Leo Siepel <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Rework caching and timeout handling * Fix another caching related issue Signed-off-by: Leo Siepel <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Rework caching and timeout handling * Fix another caching related issue Signed-off-by: Leo Siepel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the current way the binding interacts with the Plugwise API (Adam).
Previously it fired Location_count + Appliance_count +1 times a http request to the api every 5 seconds. With this change it is 1 request per 5 seconds.
Somehow the Adam is a bit slow every 15 minutes and requests take longer then 5 seconds. I also added a better timeouthandling with 3 retries.
No documentation, configuration or other changes needed for the end-user.