-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdpowerview] Add support for setting repeater LED color and brightness #12308
Merged
kaikreuzer
merged 2 commits into
openhab:main
from
jlaur:12307-hdpowerview-repeater-color-brightness
Feb 19, 2022
Merged
[hdpowerview] Add support for setting repeater LED color and brightness #12308
kaikreuzer
merged 2 commits into
openhab:main
from
jlaur:12307-hdpowerview-repeater-color-brightness
Feb 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#12307 Signed-off-by: Jacob Laursen <[email protected]>
andrewfg
requested changes
Feb 18, 2022
...ab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/Color.java
Show resolved
Hide resolved
...ab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/Color.java
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <[email protected]>
andrewfg
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…ss (openhab#12308) * Add support for setting repeater LED color and brightness. Fixes openhab#12307 Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
…ss (openhab#12308) * Add support for setting repeater LED color and brightness. Fixes openhab#12307 Signed-off-by: Jacob Laursen <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…ss (openhab#12308) * Add support for setting repeater LED color and brightness. Fixes openhab#12307 Signed-off-by: Jacob Laursen <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…ss (openhab#12308) * Add support for setting repeater LED color and brightness. Fixes openhab#12307 Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…ss (openhab#12308) * Add support for setting repeater LED color and brightness. Fixes openhab#12307 Signed-off-by: Jacob Laursen <[email protected]>
This was referenced Nov 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12307
Signed-off-by: Jacob Laursen [email protected]
Add support for setting repeater LED color and brightness. The PowerView app has a few pre-defined colors, but this PR makes it possible to freely select any RGB color.