Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wemo] add @jlaur as code-owner #12227

Merged
merged 1 commit into from
Feb 6, 2022
Merged

[Wemo] add @jlaur as code-owner #12227

merged 1 commit into from
Feb 6, 2022

Conversation

hmerk
Copy link
Contributor

@hmerk hmerk commented Feb 6, 2022

Signed-off-by: Hans-Jörg Merk [email protected]

Signed-off-by: Hans-Jörg Merk <[email protected]>
@hmerk hmerk requested a review from a team as a code owner February 6, 2022 15:14
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jlaur jlaur merged commit 65cd633 into openhab:main Feb 6, 2022
@jlaur jlaur added this to the 3.3 milestone Feb 6, 2022
@hmerk
Copy link
Contributor Author

hmerk commented Feb 6, 2022

@jlaur Don‘ think such a change needs to be added to a milestone

@jlaur jlaur removed this from the 3.3 milestone Feb 6, 2022
@jlaur
Copy link
Contributor

jlaur commented Feb 6, 2022

@hmerk - you are probably right. When not having any labels it won't be mentioned in the change log anyway, but probably safer/more correct not to add milestone.

@hmerk hmerk deleted the wemo-code-owner branch February 6, 2022 15:27
@kaikreuzer kaikreuzer added this to the 3.3 milestone Feb 7, 2022
@kaikreuzer
Copy link
Member

@jlaur No, as we had discussed, any PR should be tagged with a milestone.

@jlaur
Copy link
Contributor

jlaur commented Feb 7, 2022

@jlaur No, as we had discussed, any PR should be tagged with a milestone.

Thanks for clarifying.

NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
Signed-off-by: Hans-Jörg Merk <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Hans-Jörg Merk <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants