[teleinfo] Update translation files #12156
Conversation
Signed-off-by: Olivier Marceau <[email protected]>
| channel-type.teleinfo.currentType.label = Teleinfo Current Type | ||
| channel-type.teleinfo.currentType.label = Teleinfo Current Type | ||
| channel-type.teleinfo.currentType.label = Teleinfo Current Type |
There was a problem hiding this comment.
It looks like you have several duplicated entries in the "channel types" section.
You have 7 channel types appearing 3 times.
Please check what would be really expected.
Would it be a bug in the i18n tool ?
There was a problem hiding this comment.
I've removed the duplicated lines.
I think the i18n tool generates these entries because identical channel types are defined in several xml files.
There was a problem hiding this comment.
You should not have a channel type defined several times. That is certainly the root cause and what should be fixed. The common solution is to put channel types in a file named channels.xml.
There was a problem hiding this comment.
Yes I probably should do some clean up in the xml config files.
I wanted to have a separate xml file for each channel-group-type and it seems that channel-group-type cannot use a channel-type from another file so I end up duplicating channel-type in each xml file.
What you suggest is to aggregate every channel-group-type and channel-type in the same xml file? Isn't there a way to keep separate files?
There was a problem hiding this comment.
I am not aware of this limit.
I have not played with groups of channels very often.
I could be wrong but I think I already saw channels groups and channel types defined in separate files. Let me search an example.
There was a problem hiding this comment.
You can have a look at the NibeUplink Binding: channel-group-type and channel-type are defined in different XML files.
Apparently there is no constraint to have both in the same XML file.
There was a problem hiding this comment.
Thank you! The problem should have been located between chair and keyboard, as usual. I've submitted a new PR: #12204.
Signed-off-by: Olivier Marceau <[email protected]>
* Apply maven i18n plugin Signed-off-by: Olivier Marceau <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
* Apply maven i18n plugin Signed-off-by: Olivier Marceau <[email protected]>
* Apply maven i18n plugin Signed-off-by: Olivier Marceau <[email protected]>
* Apply maven i18n plugin Signed-off-by: Olivier Marceau <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
* Apply maven i18n plugin Signed-off-by: Olivier Marceau <[email protected]>
Signed-off-by: Olivier Marceau [email protected]
It seems that descriptions for channels added in the PR #11375 don't appear on crowdin, so this PR updates translation files.
This applies changes made by
mvn org.openhab.core.tools:i18n-maven-plugin:3.2.0:generate-default-translations -pl :org.openhab.binding.teleinfocommand.