[hdpowerview] Add firmware information properties for hub and shade

[jlaur]

Signed-off-by: Jacob Laursen [email protected]

Fixes #11979

Add firmware information for hub and shade.

Hub:

• Firmware name.
• Main processor firmware version (revision, sub revision and build).
• Radio firmware version (revision, sub revision and build); V2 Hub only

Shade:

• Firmware version (revision, sub revision and build)
• Motor firmware version (revision, sub revision and build)

These properties can be useful information for users, but also prepares the binding for handling differences between firmware versions, for example supporting functionality which is only available in V2 Hub. This was almost necessary for #11857.

[fwolter]

One of the enhancement/bug/documentation labels must be set to let the PR show up in the release notes.

[lolodomo]

You should have rather used the constant from oprnHAB core for firmware version property.

[jlaur]

You should have rather used the constant from oprnHAB core for firmware version property.

Thanks, I was unaware. I'll provide new PR.

[jlaur]

You should have rather used the constant from oprnHAB core for firmware version property.

Thanks, I was unaware. I'll provide new PR.

#11989 - luckily the property text was the same.

[andrewfg]

^
LOL, but I think he meant that you could have saved a few bytes by importing the string constants from Thing..

public interface Thing extends Identifiable<ThingUID> {
    final String PROPERTY_VENDOR = "vendor";
    final String PROPERTY_MODEL_ID = "modelId";
    final String PROPERTY_SERIAL_NUMBER = "serialNumber";
    final String PROPERTY_HARDWARE_VERSION = "hardwareVersion";
    final String PROPERTY_FIRMWARE_VERSION = "firmwareVersion";
    final String PROPERTY_MAC_ADDRESS = "macAddress";

[jlaur]

LOL, but I think he meant that you could have saved a few bytes by importing the string constants from Thing..

That's also how I understood it, and how I changed it in #11989? But now I'm not sure I understand anymore, did I miss something? :-)

[andrewfg]

I had not seen #11989 -- however I am sure that we both understand it right, and that your new PR is indeed just fine!

[jlaur]

I had not seen #11989 -- however I am sure that we both understand it right, and that your new PR is indeed just fine!

Phew, good. It was a good comment. I was completely unaware of that constant, and by pure luck hit the same name for it, even after a few iterations - originally I had them divided into separate properties for firmwareRevision, firmwareSubRevision and firmwareBuild. IMHO it's not just a few bytes, but a matter of consistency.