Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wled] Add configuration to sort state options of channels #11785

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

lordjaxom
Copy link
Contributor

As discussed in the forum, it would be nice to have the state options for the channels "effects" and "palettes" sorted like they are in the WLED mobile app, i.e. the first option at the top and the rest alphabetically. This PR adds two thing options that allows to enable exactly that on both channels separately.

https://community.openhab.org/t/mainui-sorting-choices-provided-by-thing-channel/129883/5?u=lordjaxom

This allows for displaying the channels' state options in a sorted list in the various UIs without having to maintain that list manually by adding state option metadata to items.

@lordjaxom lordjaxom requested a review from Skinah as a code owner December 15, 2021 07:46
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit a1e84cf into openhab:main Dec 15, 2021
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Dec 15, 2021
@lolodomo lolodomo added this to the 3.2 milestone Dec 15, 2021
@lordjaxom lordjaxom deleted the wled_sort_options branch December 15, 2021 10:54
@wborn wborn changed the title [wled] add configuration to sort state options of channels [wled] Add configuration to sort state options of channels Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
…d palettes (openhab#11785)

Signed-off-by: Sascha Volkenandt <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…d palettes (openhab#11785)

Signed-off-by: Sascha Volkenandt <[email protected]>
Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…d palettes (openhab#11785)

Signed-off-by: Sascha Volkenandt <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants