[jsscripting] GraalJS now uses automation/js #11719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitaldan
reviewed
Dec 7, 2021
.../src/main/java/org/openhab/automation/jsscripting/internal/fs/watch/JSDependencyTracker.java
Show resolved
Hide resolved
digitaldan
reviewed
Dec 7, 2021
.../src/main/java/org/openhab/automation/jsscripting/internal/fs/watch/JSScriptFileWatcher.java
Show resolved
Hide resolved
digitaldan
reviewed
Dec 8, 2021
...ng/src/main/java/org/openhab/automation/jsscripting/internal/GraalJSScriptEngineFactory.java
Outdated
Show resolved
Hide resolved
jpg0
force-pushed
the
js-script-dir
branch
2 times, most recently
from
bb733d1 to
bb7bac7
Compare
cweitkamp
reviewed
Dec 12, 2021
There was a problem hiding this comment.
Waiting for https://github.com/openhab/openhab-core/runs/4497892590 to succeed. Then we can rerun the build for this PR.
...ng/src/main/java/org/openhab/automation/jsscripting/internal/GraalJSScriptEngineFactory.java
Show resolved
Hide resolved
.../src/main/java/org/openhab/automation/jsscripting/internal/fs/watch/JSScriptFileWatcher.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/openhab/automation/jsscripting/internal/fs/watch/JSDependencyTracker.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/org/openhab/automation/jsscripting/internal/OpenhabGraalJSScriptEngine.java
Show resolved
Hide resolved
cweitkamp
added
enhancement
Signed-off-by: Jonathan Gilbert <[email protected]>
|
I am not sure why this is failing; has it not yet caught up with the change in core? |
cweitkamp
added
rebuild
|
@jpg0 https://ci.openhab.org/job/openHAB-Core/880/ is building right now which i think will push updated core bundles to the repos. |
kaikreuzer
added
rebuild
kaikreuzer
approved these changes
Dec 12, 2021
.../src/main/java/org/openhab/automation/jsscripting/internal/fs/watch/JSDependencyTracker.java
Outdated
Show resolved
Hide resolved
…penhab/automation/jsscripting/internal/fs/watch/JSDependencyTracker.java
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* GraalJS now uses automation/js Signed-off-by: Jonathan Gilbert <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* GraalJS now uses automation/js Signed-off-by: Jonathan Gilbert <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* GraalJS now uses automation/js Signed-off-by: Jonathan Gilbert <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* GraalJS now uses automation/js Signed-off-by: Jonathan Gilbert <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* GraalJS now uses automation/js Signed-off-by: Jonathan Gilbert <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* GraalJS now uses automation/js Signed-off-by: Jonathan Gilbert <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the 'new' GraalJS plugin to monitor
<openHAB-conf>/automation/js for scripts, with libraries in<openHAB-conf>/automation/js/node_modules- as per NodeJS standard spec.It also removes itself from monitoring the original
automation/jsr233/javascript/*directories, and instead leaves this for Nashorn. This allows users to move scripts over to GraalJS from Nashorn one-by-one.Note that this change breaks any ES6+ scripts which are in automation/jsr233/javascript/* directories. These will need to be moved to
automation/js.Note also that this PR depends on openhab/openhab-core#2593 which enables it to use it's own script directory.
Signed-off-by: Jonathan Gilbert [email protected]