[openwebnet] Reduced log messages during UPnP bridge discovery #11705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
reviewed
Dec 5, 2021
| @@ -226,7 +226,7 @@ private DeviceInfo(RemoteDevice device) { | |||
| } | |||
| } | |||
| } | |||
| logger.info("Found BTicino device: not a OpenWebNet gateway or is not supported (UDN={})", idString); | |||
| logger.info("Found BTicino device: not a OpenWebNet gateway or not supported (UDN={})", idString); | |||
There was a problem hiding this comment.
Even this one could be rather DEBUG?
We should have the minimum of INFO logs.
There was a problem hiding this comment.
I would find useful to tell the user via INFO message that the BTicino device that was found is NOT a gateway that can be used by this binding for integration. Therefore I would leave the level to INFO.
There was a problem hiding this comment.
I let another maintainer decide.
@kaikreuzer ?
Signed-off-by: Massimo Valla <[email protected]>
mvalla
force-pushed
the
openwebnet-3.2-upnp-log
branch
from
f66d03a to
dda0833
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openwebnet-bticino-openhab3/128305/9 |
|
@fwolter : please have a look, if this is ok for you to leave an INFO level log, you can merge. |
fwolter
approved these changes
Dec 12, 2021
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…ab#11705) Signed-off-by: Massimo Valla <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…ab#11705) Signed-off-by: Massimo Valla <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…ab#11705) Signed-off-by: Massimo Valla <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…ab#11705) Signed-off-by: Massimo Valla <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…ab#11705) Signed-off-by: Massimo Valla <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…ab#11705) Signed-off-by: Massimo Valla <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11701 by changing 2 log messages to DEBUG level.