[omnikinverter] Add channels for voltage and current #11645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansbogert
commented
Nov 28, 2021
.../src/main/java/org/openhab/binding/omnikinverter/internal/OmnikInverterBindingConstants.java
Show resolved
Hide resolved
hansbogert
commented
Nov 28, 2021
...r/src/main/java/org/openhab/binding/omnikinverter/internal/handler/OmnikInverterHandler.java
Outdated
Show resolved
Hide resolved
wborn
added
enhancement
hansbogert
changed the title
|
@wborn not sure how to remove the "work in progress" tag, if that's to-be changed be committer in the first place. Either way, I think a review can be done in the current state. Please also see my own review comments, which are basically questions to the reviewer. |
|
Thanks for the update! I've removed the label. 🙂 |
lolodomo
requested changes
Dec 11, 2021
.../src/main/java/org/openhab/binding/omnikinverter/internal/OmnikInverterBindingConstants.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.omnikinverter/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.omnikinverter/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.omnikinverter/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.omnikinverter/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.omnikinverter/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.omnikinverter/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
hansbogert
force-pushed
the
main
branch
2 times, most recently
from
7f102fc to
23d904d
Compare
Signed-off-by: Hans van den Bogert <[email protected]>
|
Not sure if I should explicitly ask for (re)review, so just a gentle ping @lolodomo |
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…b#11645) Signed-off-by: Hans van den Bogert <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…b#11645) Signed-off-by: Hans van den Bogert <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…b#11645) Signed-off-by: Hans van den Bogert <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…b#11645) Signed-off-by: Hans van den Bogert <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…b#11645) Signed-off-by: Hans van den Bogert <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…b#11645) Signed-off-by: Hans van den Bogert <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Novel Addition: Add multiple channels for:
These data was always already in the network packet returned by the inverter, so no new retrieval code was necessary, only extra decoding of the binary packet coming from the inverter.
For the reviewer:
Is this other than the README.md?
Is this other than the README.md?