-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XMLTV] Preparing for Crowdin and code refining #11594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
lolodomo
requested changes
Nov 16, 2021
bundles/org.openhab.binding.xmltv/src/main/resources/OH-INF/binding/binding.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.xmltv/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...b.binding.xmltv/src/main/java/org/openhab/binding/xmltv/internal/handler/ChannelHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gaël L'hopital <[email protected]>
lolodomo
requested changes
Nov 17, 2021
...nhab.binding.xmltv/src/main/java/org/openhab/binding/xmltv/internal/XmlTVHandlerFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
lolodomo
approved these changes
Nov 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lolodomo
added
enhancement
An enhancement or new feature for an existing add-on
translation
labels
Nov 20, 2021
Thank you |
You're welcome ! |
wborn
changed the title
[XMLTV] Preparing for Crowdin and code refining.
[XMLTV] Preparing for Crowdin and code refining
Dec 18, 2021
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Preparing for Crowdin and code refining. Signed-off-by: Gaël L'hopital <[email protected]> * Satisfying SAT Signed-off-by: Gaël L'hopital <[email protected]> * Preventing two potential NPE Signed-off-by: Gaël L'hopital <[email protected]> * Code review comments taken in account Signed-off-by: clinique <[email protected]> * Reverting description removal Signed-off-by: clinique <[email protected]> * Forgot spotless apply Signed-off-by: clinique <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* Preparing for Crowdin and code refining. Signed-off-by: Gaël L'hopital <[email protected]> * Satisfying SAT Signed-off-by: Gaël L'hopital <[email protected]> * Preventing two potential NPE Signed-off-by: Gaël L'hopital <[email protected]> * Code review comments taken in account Signed-off-by: clinique <[email protected]> * Reverting description removal Signed-off-by: clinique <[email protected]> * Forgot spotless apply Signed-off-by: clinique <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Preparing for Crowdin and code refining. Signed-off-by: Gaël L'hopital <[email protected]> * Satisfying SAT Signed-off-by: Gaël L'hopital <[email protected]> * Preventing two potential NPE Signed-off-by: Gaël L'hopital <[email protected]> * Code review comments taken in account Signed-off-by: clinique <[email protected]> * Reverting description removal Signed-off-by: clinique <[email protected]> * Forgot spotless apply Signed-off-by: clinique <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Preparing for Crowdin and code refining. Signed-off-by: Gaël L'hopital <[email protected]> * Satisfying SAT Signed-off-by: Gaël L'hopital <[email protected]> * Preventing two potential NPE Signed-off-by: Gaël L'hopital <[email protected]> * Code review comments taken in account Signed-off-by: clinique <[email protected]> * Reverting description removal Signed-off-by: clinique <[email protected]> * Forgot spotless apply Signed-off-by: clinique <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Preparing for Crowdin and code refining. Signed-off-by: Gaël L'hopital <[email protected]> * Satisfying SAT Signed-off-by: Gaël L'hopital <[email protected]> * Preventing two potential NPE Signed-off-by: Gaël L'hopital <[email protected]> * Code review comments taken in account Signed-off-by: clinique <[email protected]> * Reverting description removal Signed-off-by: clinique <[email protected]> * Forgot spotless apply Signed-off-by: clinique <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaël L'hopital [email protected]