Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XMLTV] Preparing for Crowdin and code refining #11594

Merged
merged 6 commits into from
Nov 20, 2021

Conversation

clinique
Copy link
Contributor

Signed-off-by: Gaël L'hopital [email protected]

Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique clinique requested a review from lolodomo November 17, 2021 10:20
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 2eb0ff5 into openhab:main Nov 20, 2021
@lolodomo lolodomo added enhancement An enhancement or new feature for an existing add-on translation labels Nov 20, 2021
@lolodomo lolodomo added this to the 3.2 milestone Nov 20, 2021
@lolodomo
Copy link
Contributor

Thank you

@clinique
Copy link
Contributor Author

You're welcome !

@wborn wborn changed the title [XMLTV] Preparing for Crowdin and code refining. [XMLTV] Preparing for Crowdin and code refining Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
* Preparing for Crowdin and code refining.

Signed-off-by: Gaël L'hopital <[email protected]>

* Satisfying SAT

Signed-off-by: Gaël L'hopital <[email protected]>

* Preventing two potential NPE

Signed-off-by: Gaël L'hopital <[email protected]>

* Code review comments taken in account

Signed-off-by: clinique <[email protected]>

* Reverting description removal

Signed-off-by: clinique <[email protected]>

* Forgot spotless apply

Signed-off-by: clinique <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
* Preparing for Crowdin and code refining.

Signed-off-by: Gaël L'hopital <[email protected]>

* Satisfying SAT

Signed-off-by: Gaël L'hopital <[email protected]>

* Preventing two potential NPE

Signed-off-by: Gaël L'hopital <[email protected]>

* Code review comments taken in account

Signed-off-by: clinique <[email protected]>

* Reverting description removal

Signed-off-by: clinique <[email protected]>

* Forgot spotless apply

Signed-off-by: clinique <[email protected]>
Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* Preparing for Crowdin and code refining.

Signed-off-by: Gaël L'hopital <[email protected]>

* Satisfying SAT

Signed-off-by: Gaël L'hopital <[email protected]>

* Preventing two potential NPE

Signed-off-by: Gaël L'hopital <[email protected]>

* Code review comments taken in account

Signed-off-by: clinique <[email protected]>

* Reverting description removal

Signed-off-by: clinique <[email protected]>

* Forgot spotless apply

Signed-off-by: clinique <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Preparing for Crowdin and code refining.

Signed-off-by: Gaël L'hopital <[email protected]>

* Satisfying SAT

Signed-off-by: Gaël L'hopital <[email protected]>

* Preventing two potential NPE

Signed-off-by: Gaël L'hopital <[email protected]>

* Code review comments taken in account

Signed-off-by: clinique <[email protected]>

* Reverting description removal

Signed-off-by: clinique <[email protected]>

* Forgot spotless apply

Signed-off-by: clinique <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Preparing for Crowdin and code refining.

Signed-off-by: Gaël L'hopital <[email protected]>

* Satisfying SAT

Signed-off-by: Gaël L'hopital <[email protected]>

* Preventing two potential NPE

Signed-off-by: Gaël L'hopital <[email protected]>

* Code review comments taken in account

Signed-off-by: clinique <[email protected]>

* Reverting description removal

Signed-off-by: clinique <[email protected]>

* Forgot spotless apply

Signed-off-by: clinique <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants