[dominoswiss] Initial contribution #11585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
added
the
new binding
wborn
reviewed
Nov 14, 2021
Signed-off-by: Frieso Aeschbacher <[email protected]>
Signed-off-by: Frieso Aeschbacher <[email protected]>
Signed-off-by: Frieso Aeschbacher <[email protected]>
fwolter
requested changes
Nov 20, 2021
...binding.dominoswiss/src/main/java/org/openhab/binding/dominoswiss/internal/EGateHandler.java
Outdated
Show resolved
Hide resolved
| localSocket.connect(new InetSocketAddress(host, port)); | ||
| localSocket.setSoTimeout(SOCKET_TIMEOUT_SEC); | ||
| BufferedWriter localWriter = writer; | ||
| localWriter = new BufferedWriter(new OutputStreamWriter(localSocket.getOutputStream())); |
There was a problem hiding this comment.
You need to close the BufferedWriter. You could use the auto-close feature:
Suggested change
| localWriter = new BufferedWriter(new OutputStreamWriter(localSocket.getOutputStream())); | |
| try(localWriter = new BufferedWriter(new OutputStreamWriter(localSocket.getOutputStream()))) { |
If I see correctly, you create new BufferedWriter/OutputStreamWriter each poll. Why not create one when connecting and close it in dispose() or disconnect? Then, you can also re-use it in sendCommand().
There was a problem hiding this comment.
I close the BufferedWriter. The redesign will be made with a later release, thanks for that hint.
There was a problem hiding this comment.
The BufferedWriter is assigned to the local variable localWriter, but this variable is out of scope if the method pollingConfig is left. So, the BufferedWrite is never closed and you will end up with a resource leak.
As said, the assignment BufferedWriter localWriter = writer; has no effect.
Signed-off-by: Frieso Aeschbacher <[email protected]>
Signed-off-by: Frieso Aeschbacher <[email protected]>
Friesoch
force-pushed
the
dominoswissInital
branch
from
419e978 to
6edcb5d
Compare
Signed-off-by: Frieso Aeschbacher <[email protected]>
fwolter
requested changes
Dec 11, 2021
Signed-off-by: Fabian Wolter <[email protected]>
fwolter
approved these changes
Dec 11, 2021
There was a problem hiding this comment.
LGTM
Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website
Dear @fwolter thanks a lot for your support and your input to bring the binding to the desired quality level :) A big thank you and cheers |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Added Dominoswiss to CODEOWNERS and POMs Signed-off-by: Frieso Aeschbacher <[email protected]> * Intitial contribution of Dominoswiss Binding Signed-off-by: Frieso Aeschbacher <[email protected]> * Typo in pom.xml Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed localWriter Issue Signed-off-by: Frieso Aeschbacher <[email protected]> * Update bom/openhab-addons/pom.xml Signed-off-by: Fabian Wolter <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* Added Dominoswiss to CODEOWNERS and POMs Signed-off-by: Frieso Aeschbacher <[email protected]> * Intitial contribution of Dominoswiss Binding Signed-off-by: Frieso Aeschbacher <[email protected]> * Typo in pom.xml Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed localWriter Issue Signed-off-by: Frieso Aeschbacher <[email protected]> * Update bom/openhab-addons/pom.xml Signed-off-by: Fabian Wolter <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Added Dominoswiss to CODEOWNERS and POMs Signed-off-by: Frieso Aeschbacher <[email protected]> * Intitial contribution of Dominoswiss Binding Signed-off-by: Frieso Aeschbacher <[email protected]> * Typo in pom.xml Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed localWriter Issue Signed-off-by: Frieso Aeschbacher <[email protected]> * Update bom/openhab-addons/pom.xml Signed-off-by: Fabian Wolter <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Added Dominoswiss to CODEOWNERS and POMs Signed-off-by: Frieso Aeschbacher <[email protected]> * Intitial contribution of Dominoswiss Binding Signed-off-by: Frieso Aeschbacher <[email protected]> * Typo in pom.xml Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed localWriter Issue Signed-off-by: Frieso Aeschbacher <[email protected]> * Update bom/openhab-addons/pom.xml Signed-off-by: Fabian Wolter <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Added Dominoswiss to CODEOWNERS and POMs Signed-off-by: Frieso Aeschbacher <[email protected]> * Intitial contribution of Dominoswiss Binding Signed-off-by: Frieso Aeschbacher <[email protected]> * Typo in pom.xml Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed localWriter Issue Signed-off-by: Frieso Aeschbacher <[email protected]> * Update bom/openhab-addons/pom.xml Signed-off-by: Fabian Wolter <[email protected]> Co-authored-by: Fabian Wolter <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Added Dominoswiss to CODEOWNERS and POMs Signed-off-by: Frieso Aeschbacher <[email protected]> * Intitial contribution of Dominoswiss Binding Signed-off-by: Frieso Aeschbacher <[email protected]> * Typo in pom.xml Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed inputs from fwolter Signed-off-by: Frieso Aeschbacher <[email protected]> * Fixed localWriter Issue Signed-off-by: Frieso Aeschbacher <[email protected]> * Update bom/openhab-addons/pom.xml Signed-off-by: Fabian Wolter <[email protected]> Co-authored-by: Fabian Wolter <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new Binding "org.openhab.binding.dominoswiss" for a first initial commit of this binding
[dominoswiss][WIP] initial contribution
added new binding org.openhab.binding.dominoswiss for initial commit
This binding allows the controll of rollershutters, using an egate as gateway and dominoswiss radio receivers. The egate-gateway is connectet via ethernet to openhab and sends it's commands via radio to all rollershutters.
Announcement: https://community.openhab.org/t/announce-dominoswiss-binding/76503
Replaces Pull-Request #9837
Jar-File for Testing:
https://github.com/Friesoch/org.openhab.binding.dominoswiss