[hdpowerview] Secondary shade position was inverted #11552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andrew Fiddian-Green <[email protected]>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* [hdpowerview] get secondary shade position value was inverted Signed-off-by: Andrew Fiddian-Green <[email protected]> * [hdpowerview] remove testing Jar from PR Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* [hdpowerview] get secondary shade position value was inverted Signed-off-by: Andrew Fiddian-Green <[email protected]> * [hdpowerview] remove testing Jar from PR Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* [hdpowerview] get secondary shade position value was inverted Signed-off-by: Andrew Fiddian-Green <[email protected]> * [hdpowerview] remove testing Jar from PR Signed-off-by: Andrew Fiddian-Green <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [hdpowerview] get secondary shade position value was inverted Signed-off-by: Andrew Fiddian-Green <[email protected]> * [hdpowerview] remove testing Jar from PR Signed-off-by: Andrew Fiddian-Green <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [hdpowerview] get secondary shade position value was inverted Signed-off-by: Andrew Fiddian-Green <[email protected]> * [hdpowerview] remove testing Jar from PR Signed-off-by: Andrew Fiddian-Green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR resolves issue #11543
Description
The shade secondary position Getter method was using inverted logic compared to the respective Setter method.
Solution
The shade secondary position Getter and Setter methods are now compatible.