Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nikobus] Added option to set rollershutter position #11548

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

crnjan
Copy link
Contributor

@crnjan crnjan commented Nov 8, 2021

As also discussed here, an option to set rollershutter's position (in %) was added. Since Nikobus's rollerhutter module does not provide positioning information, required movement is calculated based on estimated position.

Signed-off-by: Boris Krivonog [email protected]

@crnjan crnjan force-pushed the feature/rollershutter_set_posiiton branch from 5c64241 to e18de34 Compare November 8, 2021 19:45
@crnjan crnjan added the enhancement An enhancement or new feature for an existing add-on label Nov 8, 2021
Signed-off-by: Boris Krivonog [email protected]
Signed-off-by: Boris Krivonog <[email protected]>
@crnjan crnjan force-pushed the feature/rollershutter_set_posiiton branch from 75802ba to 91528d4 Compare November 8, 2021 20:51
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTN

@lolodomo lolodomo merged commit edafc19 into openhab:main Nov 14, 2021
@lolodomo lolodomo added this to the 3.2 milestone Nov 14, 2021
@crnjan crnjan deleted the feature/rollershutter_set_posiiton branch November 15, 2021 07:57
@wborn wborn changed the title [nikobus] added option to set rollershutter position [nikobus] Added option to set rollershutter position Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
Signed-off-by: Boris Krivonog [email protected]
Signed-off-by: Boris Krivonog <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
Signed-off-by: Boris Krivonog [email protected]
Signed-off-by: Boris Krivonog <[email protected]>
Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants