[nuvo] Fixes protocol errors when connecting via an MPS4 #11511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
changed the title
mlobstein
reviewed
Nov 4, 2021
...penhab.binding.nuvo/src/main/java/org/openhab/binding/nuvo/internal/handler/NuvoHandler.java
Outdated
Show resolved
Hide resolved
mlobstein
reviewed
Nov 4, 2021
...inding.nuvo/src/main/java/org/openhab/binding/nuvo/internal/communication/NuvoConnector.java
Show resolved
Hide resolved
...penhab.binding.nuvo/src/main/java/org/openhab/binding/nuvo/internal/handler/NuvoHandler.java
Outdated
Show resolved
Hide resolved
...penhab.binding.nuvo/src/main/java/org/openhab/binding/nuvo/internal/handler/NuvoHandler.java
Outdated
Show resolved
Hide resolved
...penhab.binding.nuvo/src/main/java/org/openhab/binding/nuvo/internal/handler/NuvoHandler.java
Outdated
Show resolved
Hide resolved
boc-tothefuture
force-pushed
the
nuvo_mps4_compat
branch
3 times, most recently
from
2ecec6c to
650beee
Compare
|
@mlobstein I believe I have resolved all your comments. Thanks for the review. |
mlobstein
reviewed
Nov 5, 2021
boc-tothefuture
force-pushed
the
nuvo_mps4_compat
branch
from
650beee to
b3103d7
Compare
|
@mlobstein it may be worth you trying this build against your system? I don't know if you are serial or IP over serial but I am not able to test that. |
I will test it out later tonight and report back if there are any issues. |
mlobstein
requested changes
Nov 6, 2021
...penhab.binding.nuvo/src/main/java/org/openhab/binding/nuvo/internal/handler/NuvoHandler.java
Outdated
Show resolved
Hide resolved
|
Merged your change in. |
Signed-off-by: Brian O'Connell <[email protected]>
boc-tothefuture
force-pushed
the
nuvo_mps4_compat
branch
from
1943d06 to
201f6b3
Compare
|
@mlobstein the PR still says that a review is needed. Can you approve it if you are ok with it being merged? |
mlobstein
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
@boc-tothefuture I can't merge the PR, only one of the maintainers can. I will mark the changes as approved FWIW.
@fwolter can you take a look when you have time?
fwolter
approved these changes
Nov 10, 2021
jpg0
pushed a commit
to jpg0/openhab-addons
that referenced
this pull request
Nov 10, 2021
Signed-off-by: Brian O'Connell <[email protected]> Co-authored-by: Brian O'Connell <[email protected]>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
Signed-off-by: Brian O'Connell <[email protected]> Co-authored-by: Brian O'Connell <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
Signed-off-by: Brian O'Connell <[email protected]> Co-authored-by: Brian O'Connell <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
Signed-off-by: Brian O'Connell <[email protected]> Co-authored-by: Brian O'Connell <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Brian O'Connell <[email protected]> Co-authored-by: Brian O'Connell <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Brian O'Connell <[email protected]> Co-authored-by: Brian O'Connell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brian O'Connell [email protected]
fix[nuvo] fixes protocol errors when connecting via an MPS4
This fixes the error when using the Nuvo binding over IP through an MPS4 the binding would be disconnected over and over again. The MPS4 will disconnect connections when requests are sent and no zones are on. The MPS4 sends a PING command every 10 seconds, this update listens for that ping and if a ping is not received in minute initiates a reconnection if the user has indicated they are using the MPS4.
This issue is noted by another user in the forum here