[chromecast] Added support for next command #11510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian O'Connell <[email protected]>
boc-tothefuture
force-pushed
the
chromecast_next
branch
from
24c7e52 to
cbe4024
Compare
wborn
changed the title
lolodomo
reviewed
Nov 12, 2021
...ng.chromecast/src/main/java/org/openhab/binding/chromecast/internal/ChromecastCommander.java
Outdated
Show resolved
Hide resolved
lolodomo
added
the
awaiting feedback
|
@boc-tothefuture : no time to answer to my comment ? |
Didn't see the notification. Sorry. |
boc-tothefuture
force-pushed
the
chromecast_next
branch
from
6e62b10 to
63d2237
Compare
lolodomo
removed
the
awaiting feedback
|
Please sign property your last commit. |
|
Let's make an exception as the initial PR was correctly signed. |
|
@lolodomo sorry for the delay.. For some reason I am not seeing notifications from this repo, and only this repo. I will recheck my setting. |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* feat(chromecast): added support for next command Signed-off-by: Brian O'Connell <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* feat(chromecast): added support for next command Signed-off-by: Brian O'Connell <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* feat(chromecast): added support for next command Signed-off-by: Brian O'Connell <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* feat(chromecast): added support for next command Signed-off-by: Brian O'Connell <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* feat(chromecast): added support for next command Signed-off-by: Brian O'Connell <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* feat(chromecast): added support for next command Signed-off-by: Brian O'Connell <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[chromecast] Next Command Support
Add support for next command to chromecast binding, this is implemented by seeking to the end of the current track as there is no native next command. This is the same implementation for next that the python library uses for chromecast, which is used by home assistant to achieve this functionality.