[wled] Abstract json api for better segment support #11509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/wled-binding-newer-json-api-beta/128405/1 |
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
fwolter
approved these changes
Nov 20, 2021
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Change to json for states Signed-off-by: Matthew Skinner <[email protected]> * Add 3rd colours. Signed-off-by: Matthew Skinner <[email protected]> * Segments now mostly work Signed-off-by: Matthew Skinner <[email protected]> * changes to json api fully made Signed-off-by: Matthew Skinner <[email protected]> * Mirror and Reverse channels added. Signed-off-by: Matthew Skinner <[email protected]> * Remove old channels when needed. Signed-off-by: Matthew Skinner <[email protected]> * Simplify return Signed-off-by: Matthew Skinner <[email protected]> * Add support for named presets Signed-off-by: Matthew Skinner <[email protected]> * Dont add empty preset 0 to list Signed-off-by: Matthew Skinner <[email protected]> * Add preset saving with custom names Signed-off-by: Matthew Skinner <[email protected]> * Tidy up Signed-off-by: Matthew Skinner <[email protected]> * Rename function for clarity Signed-off-by: Matthew Skinner <[email protected]> * Add more channels Signed-off-by: Matthew Skinner <[email protected]> * Clean up Signed-off-by: Matthew Skinner <[email protected]> * Fix bugs and update readme for new channels Signed-off-by: Matthew Skinner <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* Change to json for states Signed-off-by: Matthew Skinner <[email protected]> * Add 3rd colours. Signed-off-by: Matthew Skinner <[email protected]> * Segments now mostly work Signed-off-by: Matthew Skinner <[email protected]> * changes to json api fully made Signed-off-by: Matthew Skinner <[email protected]> * Mirror and Reverse channels added. Signed-off-by: Matthew Skinner <[email protected]> * Remove old channels when needed. Signed-off-by: Matthew Skinner <[email protected]> * Simplify return Signed-off-by: Matthew Skinner <[email protected]> * Add support for named presets Signed-off-by: Matthew Skinner <[email protected]> * Dont add empty preset 0 to list Signed-off-by: Matthew Skinner <[email protected]> * Add preset saving with custom names Signed-off-by: Matthew Skinner <[email protected]> * Tidy up Signed-off-by: Matthew Skinner <[email protected]> * Rename function for clarity Signed-off-by: Matthew Skinner <[email protected]> * Add more channels Signed-off-by: Matthew Skinner <[email protected]> * Clean up Signed-off-by: Matthew Skinner <[email protected]> * Fix bugs and update readme for new channels Signed-off-by: Matthew Skinner <[email protected]> Signed-off-by: Michael Schmidt <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Change to json for states Signed-off-by: Matthew Skinner <[email protected]> * Add 3rd colours. Signed-off-by: Matthew Skinner <[email protected]> * Segments now mostly work Signed-off-by: Matthew Skinner <[email protected]> * changes to json api fully made Signed-off-by: Matthew Skinner <[email protected]> * Mirror and Reverse channels added. Signed-off-by: Matthew Skinner <[email protected]> * Remove old channels when needed. Signed-off-by: Matthew Skinner <[email protected]> * Simplify return Signed-off-by: Matthew Skinner <[email protected]> * Add support for named presets Signed-off-by: Matthew Skinner <[email protected]> * Dont add empty preset 0 to list Signed-off-by: Matthew Skinner <[email protected]> * Add preset saving with custom names Signed-off-by: Matthew Skinner <[email protected]> * Tidy up Signed-off-by: Matthew Skinner <[email protected]> * Rename function for clarity Signed-off-by: Matthew Skinner <[email protected]> * Add more channels Signed-off-by: Matthew Skinner <[email protected]> * Clean up Signed-off-by: Matthew Skinner <[email protected]> * Fix bugs and update readme for new channels Signed-off-by: Matthew Skinner <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Change to json for states Signed-off-by: Matthew Skinner <[email protected]> * Add 3rd colours. Signed-off-by: Matthew Skinner <[email protected]> * Segments now mostly work Signed-off-by: Matthew Skinner <[email protected]> * changes to json api fully made Signed-off-by: Matthew Skinner <[email protected]> * Mirror and Reverse channels added. Signed-off-by: Matthew Skinner <[email protected]> * Remove old channels when needed. Signed-off-by: Matthew Skinner <[email protected]> * Simplify return Signed-off-by: Matthew Skinner <[email protected]> * Add support for named presets Signed-off-by: Matthew Skinner <[email protected]> * Dont add empty preset 0 to list Signed-off-by: Matthew Skinner <[email protected]> * Add preset saving with custom names Signed-off-by: Matthew Skinner <[email protected]> * Tidy up Signed-off-by: Matthew Skinner <[email protected]> * Rename function for clarity Signed-off-by: Matthew Skinner <[email protected]> * Add more channels Signed-off-by: Matthew Skinner <[email protected]> * Clean up Signed-off-by: Matthew Skinner <[email protected]> * Fix bugs and update readme for new channels Signed-off-by: Matthew Skinner <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Change to json for states Signed-off-by: Matthew Skinner <[email protected]> * Add 3rd colours. Signed-off-by: Matthew Skinner <[email protected]> * Segments now mostly work Signed-off-by: Matthew Skinner <[email protected]> * changes to json api fully made Signed-off-by: Matthew Skinner <[email protected]> * Mirror and Reverse channels added. Signed-off-by: Matthew Skinner <[email protected]> * Remove old channels when needed. Signed-off-by: Matthew Skinner <[email protected]> * Simplify return Signed-off-by: Matthew Skinner <[email protected]> * Add support for named presets Signed-off-by: Matthew Skinner <[email protected]> * Dont add empty preset 0 to list Signed-off-by: Matthew Skinner <[email protected]> * Add preset saving with custom names Signed-off-by: Matthew Skinner <[email protected]> * Tidy up Signed-off-by: Matthew Skinner <[email protected]> * Rename function for clarity Signed-off-by: Matthew Skinner <[email protected]> * Add more channels Signed-off-by: Matthew Skinner <[email protected]> * Clean up Signed-off-by: Matthew Skinner <[email protected]> * Fix bugs and update readme for new channels Signed-off-by: Matthew Skinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to using the json API which has more features then the older http based API and gets better testing.
New features that the changes also bring:
Precompiled jar found at link below or it can be installed via the marketplace:
http://pcmus.com/openhab/wled/
Due to new channels getting added, please delete and re-add the things if you use the UI. If you use textual things then no need to do that.
Signed-off-by: Matthew Skinner [email protected]