Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipcamera] Fix Hikvision digest stopping ipcamera.mjpeg #11457

Merged
merged 18 commits into from
Oct 30, 2021

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Oct 27, 2021

A fix that appears to be caused by the 401 message from digest auth getting sent out as the first jpg frame and hence stops the stream from working if Digest is on a Hikvision. Other brands don't seem effected.

Signed-off-by: Matthew Skinner [email protected]

Skinah added 18 commits October 14, 2021 21:23
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Matthew Skinner <[email protected]>
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 28, 2021
@Skinah Skinah added the bug An unexpected problem or unintended behavior of an add-on label Oct 29, 2021
@fwolter fwolter merged commit 73b4dbe into openhab:main Oct 30, 2021
@fwolter fwolter added this to the 3.2 milestone Oct 30, 2021
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <[email protected]>

* Improve and fix generic cams

Signed-off-by: Matthew Skinner <[email protected]>

* Stop dahua IntelliFrame logging

Signed-off-by: Matthew Skinner <[email protected]>

* Catch IllegalStateException

Signed-off-by: Matthew Skinner <[email protected]>

* Trial reusing channels.

Signed-off-by: Matthew Skinner <[email protected]>

* Tidy up

Signed-off-by: Matthew Skinner <[email protected]>

* cleanup 2

Signed-off-by: Matthew Skinner <[email protected]>

* Cleanup 3

Signed-off-by: Matthew Skinner <[email protected]>

* Disable checking connection with event stream.

Signed-off-by: Matthew Skinner <[email protected]>

* Bug fix

Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup

Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup

Signed-off-by: Matthew Skinner <[email protected]>

* Reduce logging to only whats needed.

Signed-off-by: Matthew Skinner <[email protected]>

* fix offline detection.

Signed-off-by: Matthew Skinner <[email protected]>

* fixes to ipcamera.mjpeg

Signed-off-by: Matthew Skinner <[email protected]>

* reverse some connection checks

Signed-off-by: Matthew Skinner <[email protected]>

* Fix Hikvision Digest stops ipcamera.mjpeg

Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Dave J Schoepel <[email protected]>
jpg0 pushed a commit to jpg0/openhab-addons that referenced this pull request Nov 10, 2021
* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <[email protected]>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <[email protected]>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <[email protected]>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <[email protected]>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <[email protected]>

* Tidy up


Signed-off-by: Matthew Skinner <[email protected]>

* cleanup 2


Signed-off-by: Matthew Skinner <[email protected]>

* Cleanup 3


Signed-off-by: Matthew Skinner <[email protected]>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <[email protected]>

* Bug fix


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup

Signed-off-by: Matthew Skinner <[email protected]>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <[email protected]>

* fix offline detection.


Signed-off-by: Matthew Skinner <[email protected]>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>

* reverse some connection checks


Signed-off-by: Matthew Skinner <[email protected]>

* Fix Hikvision Digest stops ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>
@Skinah Skinah deleted the camera branch November 30, 2021 10:17
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <[email protected]>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <[email protected]>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <[email protected]>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <[email protected]>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <[email protected]>

* Tidy up


Signed-off-by: Matthew Skinner <[email protected]>

* cleanup 2


Signed-off-by: Matthew Skinner <[email protected]>

* Cleanup 3


Signed-off-by: Matthew Skinner <[email protected]>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <[email protected]>

* Bug fix


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup

Signed-off-by: Matthew Skinner <[email protected]>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <[email protected]>

* fix offline detection.


Signed-off-by: Matthew Skinner <[email protected]>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>

* reverse some connection checks


Signed-off-by: Matthew Skinner <[email protected]>

* Fix Hikvision Digest stops ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>
Signed-off-by: Nick Waterton <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <[email protected]>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <[email protected]>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <[email protected]>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <[email protected]>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <[email protected]>

* Tidy up


Signed-off-by: Matthew Skinner <[email protected]>

* cleanup 2


Signed-off-by: Matthew Skinner <[email protected]>

* Cleanup 3


Signed-off-by: Matthew Skinner <[email protected]>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <[email protected]>

* Bug fix


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup

Signed-off-by: Matthew Skinner <[email protected]>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <[email protected]>

* fix offline detection.


Signed-off-by: Matthew Skinner <[email protected]>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>

* reverse some connection checks


Signed-off-by: Matthew Skinner <[email protected]>

* Fix Hikvision Digest stops ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <[email protected]>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <[email protected]>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <[email protected]>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <[email protected]>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <[email protected]>

* Tidy up


Signed-off-by: Matthew Skinner <[email protected]>

* cleanup 2


Signed-off-by: Matthew Skinner <[email protected]>

* Cleanup 3


Signed-off-by: Matthew Skinner <[email protected]>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <[email protected]>

* Bug fix


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup

Signed-off-by: Matthew Skinner <[email protected]>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <[email protected]>

* fix offline detection.


Signed-off-by: Matthew Skinner <[email protected]>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>

* reverse some connection checks


Signed-off-by: Matthew Skinner <[email protected]>

* Fix Hikvision Digest stops ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Stop hik logging 401 with digest.

Signed-off-by: Matthew Skinner <[email protected]>

* Improve and fix generic cams


Signed-off-by: Matthew Skinner <[email protected]>

* Stop dahua IntelliFrame logging


Signed-off-by: Matthew Skinner <[email protected]>

* Catch IllegalStateException


Signed-off-by: Matthew Skinner <[email protected]>

* Trial reusing channels.


Signed-off-by: Matthew Skinner <[email protected]>

* Tidy up


Signed-off-by: Matthew Skinner <[email protected]>

* cleanup 2


Signed-off-by: Matthew Skinner <[email protected]>

* Cleanup 3


Signed-off-by: Matthew Skinner <[email protected]>

* Disable checking connection with event stream.


Signed-off-by: Matthew Skinner <[email protected]>

* Bug fix


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup


Signed-off-by: Matthew Skinner <[email protected]>

* more cleanup

Signed-off-by: Matthew Skinner <[email protected]>

* Reduce logging to only whats needed.


Signed-off-by: Matthew Skinner <[email protected]>

* fix offline detection.


Signed-off-by: Matthew Skinner <[email protected]>

* fixes to ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>

* reverse some connection checks


Signed-off-by: Matthew Skinner <[email protected]>

* Fix Hikvision Digest stops ipcamera.mjpeg


Signed-off-by: Matthew Skinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants